Skip to content

Comments

chore: more compact invalidated query param#9708

Merged
Rich-Harris merged 3 commits intomasterfrom
compacter-x-sveltekit-invalidated
May 4, 2023
Merged

chore: more compact invalidated query param#9708
Rich-Harris merged 3 commits intomasterfrom
compacter-x-sveltekit-invalidated

Conversation

@gtm-nayan
Copy link
Contributor

@gtm-nayan gtm-nayan commented Apr 19, 2023

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

It's shorter this way, and arguably more human-readable/debuggable?
image

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

🦋 Changeset detected

Latest commit: 6daea9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rich-Harris Rich-Harris merged commit 6a0324c into master May 4, 2023
@Rich-Harris Rich-Harris deleted the compacter-x-sveltekit-invalidated branch May 4, 2023 02:36
@github-actions github-actions bot mentioned this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants