This repository was archived by the owner on Feb 6, 2023. It is now read-only.
fixed #3 #4
Merged
fixed #3 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the canvas.save() and canvas.restore() in the drawShape() function wasn't paired when `strokeWidth != null && strokeWidth > 0` fails. When we set the stroke to be transparent, the `strokeWidth != null && strokeWidth > 0` fail, and the canvas.restore() wasn't called. I've adjusted the `canvas.restore()` call to a proper position in this commit.
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the canvas.save() and canvas.restore() in the
drawShape()function weren't paired whenstrokeWidth != null && strokeWidth > 0fails. When we set the stroke to be transparent, the conditionstrokeWidth != null && strokeWidth > 0fails, and the canvas.restore() function that was inside the condition block wasn't called.I've adjusted the
canvas.restore()call to a proper position in this commit.