TypeScript and Packages

[aersam]

If I use a config file for TypeScript-Angular and I set modelPackage and apiPackage to different values, I get an error. The generated api File does no longer find the models. Maybe we should use absolut Types? Eg, services.Bla instead of just Bla?

[wing328]

@aersamkull Yes, I think that's one way to do it.

Another approach (a bit more difficult) is to import the models in the Api files, e.g. Java/api.mustache#L9

[aersam]

I think the import approach is cleaner. However the syntax is different from Java. Is there a way to add Mustache Variables for a specific language? Or to modify them?
A third approach would be Type Aliases:

type Person = ModelNamespace.Person;

[wing328]

Using the Petstore example, can you please show me what the import statement looks like?

[aersam]

Sorry, import statements are not an option. They are bound to modules and we should not rely on a module system, I think. Type Aliases could be used like imports in Java:

//PetAPI.ts
namespace API.Access {
    'use strict';
    type Pet = API.Model.Pet;

[aersam]

Somehow, api.d.ts is always location in API/Client folder and has wrong paths. This had to be fixed as well. I would expect it to be in the "apiPackage"-Folder

[wing328]

Also we need to apply the same fix to typescript-node as well but I'm not sure which one (type aliases or fully-qualified name) is preferable in typescript-node.

[aersam]

I personally prefer fully qualified names. Even though it is not very likely, we could produce name collisions with aliases.
In addition, we can write unit tests for full qualified names, isnt' it?

[wing328]

Yes, unit testing is something we need for Typescript Petstore client. I'll create a separate task for tracking that.

[wing328]

@aersamkull #1487 merged into master. Please pull the latest and let us know if you still encounter the issue.

Thanks @daveholladay for the fix.

[pixelshaded]

Still an issue. Execute this command in master:

java -jar "./modules/swagger-codegen-cli/target/swagger-codegen-cli.jar" generate -i modules/swagger-codegen/src/test/resources/2_0/petstore.json -l typescript-angular -o samples/client/petstore/typescript-angular --additional-properties modelPackage=api.clients.petstore.models

And then run npm install / test in the typescript-angular samples (you should probably delete the api folder before running the above command).

error TS6053: File 'API/Client/Category.ts' not found.
error TS6053: File 'API/Client/Order.ts' not found.
error TS6053: File 'API/Client/Pet.ts' not found.
error TS6053: File 'API/Client/Tag.ts' not found.
error TS6053: File 'API/Client/User.ts' not found.

The output references don't look in the subfolders when using namespaces.

The api.d.mustache is using classname to render which may not take in to account namespace.

{{#models}}
{{#model}}
/// <reference path="{{{classname}}}.ts" />
{{/model}}
{{/models}}

{{#apiInfo}}
{{#apis}}
{{#operations}}
/// <reference path="{{classname}}.ts" />
{{/operations}}
{{/apis}}
{{/apiInfo}}

Generates

/// <reference path="Category.ts" />
/// <reference path="Order.ts" />
/// <reference path="Pet.ts" />
/// <reference path="Tag.ts" />
/// <reference path="User.ts" />

/// <reference path="PetApi.ts" />
/// <reference path="StoreApi.ts" />
/// <reference path="UserApi.ts" />