[JavaScript] Strange enum generation

[delenius]

It seems that the generation of enums in the JS client generator is a bit odd. Currently, I get something like (omitting comments):

var AccountTypeEnum = function AccountTypeEnum() {
  var self = this;
  self.PAIDACCOUNT = "paidAccount",
  self.FREEACCOUNT = "freeAccount"
}

This is a class, where each instance has its own copy of the fields PAIDACCOUNT and FREEACCOUNT. To use this, you would currently have to do:

var myAccountType = new AccountTypeEnum();
doSomething(myAccountType.PAIDACCOUNT);

This is a strange way to encode enums.

I propose that we change it to just an object,

var AccountTypeEnum = {
  PAIDACCOUNT: "paidAccount",
  FREEACCOUNT: "freeAccount"
}

The usage would then be

doSomething(AccountTypeEnum.PAIDACCOUNT);

If the powers that be agree, I can file a PR.

[wing328]

@delenius agree that your approach is better as there's no need to crete a new object in order to use the enum values.

[delenius]

Ok. And just to double-check, these enums aren't actually used anywhere currently, right?

[wing328]

PR merged. I don't think it's used. There's no test case I'm aware of for any models in Petstore sample.

We would appreciate if you can add a few test cases for Pet model

• to test enum "status"
• to test constructFromObject