C# Why does it make properties nullable?

[SergeySagan]

I noticed that the autogen automatically changes many properties to nullable type! I assume that this is to allow the constructor to default to null to nonsupplied params...unfortunately this breaks my deal. Is there anyway to prevent the constructor generation as well as prevent the making of those non-nullable properties on source to be nullable?

[kbrooks]

Swagger has a "required" property for parameters. If this is not set to true, the codegen will make the corresponding parameters nullable.

[SergeySagan]

So you're saying I have to decorate my properties on my server with
required, even for things like public long ID? That doesn't make sense! Why
is it changing the type at all? Leave it as is in the source! Is there no
other way?

On Mon, May 16, 2016, 5:50 PM Kyle Brooks notifications@github.com wrote:

Swagger has a "required" property for parameters. If this is not set to
true, the codegen will make the corresponding parameters nullable.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#2885 (comment)

[wing328]

@serjster can you elaborate a bit more on the issue cased by nullable type?

[kbrooks]

What does your swagger.json look like?

[SergeySagan]

Sure. I've written a script that adds an IType (or whatever Type happens to
be)to each of the genned classes. The problem is that because those
properties are nullable, the compiler throws an error because "interface is
not implemented". So, instead of being able to use the genned class as the
concrete implementation for my IType interface, I have to go back and
remove all of these nullables first. I am dealing with some complex objects
here, so in my case I have over 260 errors to fix! This will not work if I
have to fix them each time I re-gen the classes.

On Mon, May 16, 2016, 6:24 PM Kyle Brooks notifications@github.com wrote:

What does your swagger.json look like?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2885 (comment)

[SergeySagan]

Here's the JSON:

{"swagger":"2.0","info":{"version":"v1","title":"iUS Claim Service
API","description":"iUS Claim Service API for retrieving all things... wait
for it... Claim
related.","termsOfService":""},"basePath":"/Benefits/Services/ClaimManagementService","paths":{"/v1/Claim/{ClaimID}":{"get":{"tags":["Claim"],"operationId":"V1ClaimByClaimIDGet","produces":["application/json","text/json","application/hal+json","text/plain"],"parameters":[{"name":"ClaimID","in":"path","required":true,"type":"integer","format":"int64"}],"responses":{"200":{"description":"OK","schema":{"$ref":"#/definitions/IResource"}}},"deprecated":false}},"/api/Entitlement/{claimantID}":{"get":{"tags":["Entitlement"],"operationId":"ApiEntitlementByClaimantIDGet","produces":["application/json","text/json","application/hal+json","text/plain"],"parameters":[{"name":"claimantID","in":"path","required":true,"type":"integer","format":"int64"}],"responses":{"200":{"description":"OK","schema":{"type":"array","items":{"$ref":"#/definitions/IClaimEntitlement"}}}},"deprecated":false}},"/api/Entitlement/{claimID}":{"get":{"tags":["Entitlement"],"operationId":"ApiEntitlementByClaimIDGet","produces":["application/json","text/json","application/hal+json","text/plain"],"parameters":[{"name":"claimID","in":"path","required":true,"type":"integer","format":"int64"}],"responses":{"200":{"description":"OK","schema":{"type":"array","items":{"$ref":"#/definitions/IClaimEntitlement"}}}},"deprecated":false}},"/api/Entitlement/{id}":{"get":{"tags":["Entitlement"],"operationId":"ApiEntitlementByIdGet","produces":["application/json","text/json","application/hal+json","text/plain"],"parameters":[{"name":"id","in":"path","required":true,"type":"integer","format":"int32"}],"responses":{"200":{"description":"OK","schema":{"$ref":"#/definitions/IClaimEntitlement"}}},"deprecated":false}},"/Error/Exception":{"get":{"tags":["Error"],"operationId":"ErrorExceptionGet","produces":["application/json","text/json","application/hal+json","text/plain"],"responses":{"200":{"description":"OK","schema":{"$ref":"#/definitions/IResource"}}},"deprecated":false}},"/Error/DevException":{"get":{"tags":["Error"],"operationId":"ErrorDevExceptionGet","produces":["application/json","text/json","application/hal+json","text/plain"],"responses":{"200":{"description":"OK","schema":{"$ref":"#/definitions/IResource"}}},"deprecated":false}},"/Health":{"get":{"tags":["Health"],"operationId":"HealthGet","produces":["application/json","text/json","application/hal+json","text/plain"],"responses":{"200":{"description":"OK","schema":{"$ref":"#/definitions/IResource"}}},"deprecated":false}},"/Health/{id}":{"get":{"tags":["Health"],"operationId":"HealthByIdGet","produces":["application/json","text/json","application/hal+json","text/plain"],"parameters":[{"name":"id","in":"path","required":true,"type":"string"}],"responses":{"200":{"description":"OK","schema":{"$ref":"#/definitions/IResource"}}},"deprecated":false}},"/v1":{"get":{"tags":["Home"],"operationId":"V1Get","produces":["application/json","text/json","application/hal+json","text/plain"],"responses":{"200":{"description":"OK","schema":{"$ref":"#/definitions/IResource"}}},"deprecated":false}},"/v1/Search":{"get":{"tags":["Search"],"operationId":"V1SearchGet","produces":["application/json","text/json","application/hal+json","text/plain"],"responses":{"200":{"description":"OK","schema":{"$ref":"#/definitions/IResource"}}},"deprecated":false}},"/v1/Search/Claim/{ClaimID}":{"get":{"tags":["Search"],"operationId":"V1SearchClaimByClaimIDGet","produces":["application/json","text/json","application/hal+json","text/plain"],"parameters":[{"name":"claimID","in":"path","required":true,"type":"integer","format":"int64"}],"responses":{"200":{"description":"OK","schema":{"$ref":"#/definitions/IResource"}}},"deprecated":false}}},"definitions":{"IResource":{"type":"object","properties":{"_links":{"type":"array","items":{"$ref":"#/definitions/Link"}}}},"Link":{"type":"object","properties":{"Curie":{"$ref":"#/definitions/CuriesLink","readOnly":true},"Rel":{"type":"string"},"Href":{"type":"string"},"Title":{"type":"string"},"Type":{"type":"string"},"Deprecation":{"type":"string"},"Name":{"type":"string"},"Profile":{"type":"string"},"HrefLang":{"type":"string"},"IsTemplated":{"type":"boolean","readOnly":true}}},"CuriesLink":{"type":"object","properties":{"Name":{"type":"string","readOnly":true},"Href":{"type":"string","readOnly":true}}},"IClaimEntitlement":{"type":"object","properties":{"Claim":{"$ref":"#/definitions/IClaim"},"ClaimEntitlementMonetaries":{"type":"array","items":{"$ref":"#/definitions/IClaimEntitlementMonetary"}},"ClaimID":{"format":"int64","type":"integer"},"CurrentClaimEntitlementMonetary":{"$ref":"#/definitions/IClaimEntitlementMonetary","readOnly":true},"FiledDate":{"format":"date-time","type":"string"},"LowRemainingBalanceAmount":{"format":"double","type":"number"},"PendingClaimEntitlementMonetary":{"$ref":"#/definitions/IClaimEntitlementMonetary","readOnly":true},"ProgramStatus":{"$ref":"#/definitions/IProgramStatus"},"ProgramStatusID":{"format":"int32","type":"integer"},"ProgramType":{"$ref":"#/definitions/IProgramType"},"ProgramTypeID":{"format":"int32","type":"integer"},"RemainingBalanceAmount":{"format":"double","type":"number"},"StartDate":{"format":"date-time","type":"string"},"ID":{"format":"int64","type":"integer"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IClaim":{"type":"object","properties":{"ABPAffidavitMailedDate":{"format":"date-time","type":"string"},"AgentStateID":{"format":"int32","type":"integer"},"BenefitYearBegin":{"format":"date-time","type":"string"},"BenefitYearEnd":{"format":"date-time","type":"string"},"ClaimantID":{"format":"int64","type":"integer"},"ClaimApplicationID":{"format":"int32","type":"integer"},"ClaimChannelType":{"$ref":"#/definitions/IClaimChannelType"},"ClaimChannelTypeID":{"format":"int32","type":"integer"},"ClaimDeductions":{"type":"array","items":{"$ref":"#/definitions/IClaimDeduction"}},"ClaimEntitlement":{"$ref":"#/definitions/IClaimEntitlement"},"ClaimExtensions":{"type":"array","items":{"$ref":"#/definitions/IClaimExtension"}},"ClaimType":{"$ref":"#/definitions/IClaimType"},"ClaimTypeID":{"format":"int32","type":"integer"},"ClaimWageRequests":{"type":"array","items":{"$ref":"#/definitions/IClaimWageRequest"}},"CWCDispositionID":{"format":"int32","type":"integer"},"DisabilityEndDate":{"format":"date-time","type":"string"},"DisabilityStartDate":{"format":"date-time","type":"string"},"ExpirationMailedDate":{"format":"date-time","type":"string"},"FileDate":{"format":"date-time","type":"string"},"IsABPAffidavitRequired":{"type":"boolean"},"IsExpirationMailingRequired":{"type":"boolean"},"IsTTDVerificationMailed":{"type":"boolean"},"IsWithdrawn":{"type":"boolean"},"LiableStateID":{"format":"int32","type":"integer"},"SocID":{"format":"int64","type":"integer"},"TenureEndDate":{"format":"date-time","type":"string"},"TenureStartDate":{"format":"date-time","type":"string"},"UCFEAssignmentStateID":{"format":"int32","type":"integer"},"UCXAssignmentStateID":{"format":"int32","type":"integer"},"UploadedBy":{"format":"int64","type":"integer"},"WageMixTypeID":{"format":"int32","type":"integer"},"WithdrawnDate":{"format":"date-time","type":"string"},"ID":{"format":"int64","type":"integer"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IClaimEntitlementMonetary":{"type":"object","properties":{"BasePeriodStartingQuarter":{"format":"int32","type":"integer"},"BasePeriodStartingYear":{"format":"int32","type":"integer"},"BasePeriodType":{"$ref":"#/definitions/IBasePeriodType"},"BasePeriodTypeID":{"format":"int32","type":"integer"},"BatchGUID":{"type":"string"},"ClaimEntitlement":{"$ref":"#/definitions/IClaimEntitlement"},"ClaimEntitlementID":{"format":"int64","type":"integer"},"IsCurrent":{"type":"boolean"},"IsLowMonetaryCalculated":{"type":"boolean","readOnly":true},"IsMailingRequired":{"type":"boolean"},"IsNotification":{"type":"boolean"},"IsPending":{"type":"boolean"},"IsPendingRequests":{"type":"boolean"},"LowTotalBenefitAmount":{"format":"double","type":"number"},"LowWeeklyBenefitAmount":{"format":"double","type":"number"},"MailedDate":{"format":"date-time","type":"string"},"MonetaryStatus":{"format":"int32","type":"integer","readOnly":true},"MonetaryType":{"$ref":"#/definitions/IMonetaryType"},"MonetaryTypeID":{"format":"int32","type":"integer"},"TotalBenefitAmount":{"format":"double","type":"number"},"WeeklyBenefitAmount":{"format":"double","type":"number"},"ID":{"format":"int64","type":"integer"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IProgramStatus":{"type":"object","properties":{"IsChargeabilityEditAllowed":{"type":"boolean"},"IsClaimReopenAllowed":{"type":"boolean"},"IsMonetarilyEligible":{"type":"boolean"},"ID":{"format":"int32","type":"integer"},"Name":{"type":"string"}}},"IProgramType":{"type":"object","properties":{"AccountingKey":{"type":"string"},"Description":{"type":"string"},"ProgramID":{"format":"int32","type":"integer"},"ShortName":{"type":"string"},"ID":{"format":"int32","type":"integer"},"Name":{"type":"string"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IClaimChannelType":{"type":"object","properties":{"ID":{"format":"int32","type":"integer"},"Name":{"type":"string"}}},"IClaimDeduction":{"type":"object","properties":{"Amount":{"format":"double","type":"number"},"Claim":{"$ref":"#/definitions/IClaim"},"ClaimDeductionFrequencyType":{"$ref":"#/definitions/IClaimDeductionFrequencyType"},"ClaimDeductionType":{"$ref":"#/definitions/IClaimDeductionType"},"ClaimDeductionTypeID":{"format":"int32","type":"integer"},"ClaimID":{"format":"int64","type":"integer"},"EndDate":{"format":"date-time","type":"string"},"FrequencyTypeID":{"format":"int32","type":"integer"},"MonthlyCap":{"format":"double","type":"number"},"StartDate":{"format":"date-time","type":"string"},"ID":{"format":"int64","type":"integer"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IClaimExtension":{"type":"object","properties":{"AlternateWeeklyBenefitAmount":{"format":"double","type":"number"},"CertificationDate":{"format":"date-time","type":"string"},"Claim":{"$ref":"#/definitions/IClaim"},"ClaimExtensionMonetaries":{"type":"array","items":{"$ref":"#/definitions/IClaimExtensionMonetary"}},"ClaimExtensionReductions":{"type":"array","items":{"$ref":"#/definitions/IClaimExtensionReduction"}},"ClaimID":{"format":"int64","type":"integer"},"CurrentClaimExtensionMonetary":{"$ref":"#/definitions/IClaimExtensionMonetary","readOnly":true},"DeterminationMailedDate":{"format":"date-time","type":"string"},"EmployerName":{"type":"string"},"EndDate":{"format":"date-time","type":"string"},"FiledDate":{"format":"date-time","type":"string"},"FirstQualifyingSeparationDate":{"format":"date-time","type":"string"},"FixedTotalBenefitAmount":{"format":"double","type":"number"},"HasJobProspects":{"type":"boolean"},"ImpactDate":{"format":"date-time","type":"string"},"IsManuallyQualified":{"type":"boolean"},"IsWithdrawn":{"type":"boolean"},"LowRemainingBalanceAmount":{"format":"double","type":"number"},"ManualWeeklyBenefitAmountMultiplier":{"format":"int32","type":"integer"},"PetitionFiledDate":{"format":"date-time","type":"string"},"ProgramStatus":{"$ref":"#/definitions/IProgramStatus"},"ProgramStatusID":{"format":"int32","type":"integer"},"ProgramType":{"$ref":"#/definitions/IProgramType"},"ProgramTypeID":{"format":"int32","type":"integer"},"RemainingBalanceAmount":{"format":"double","type":"number"},"SeparationDate":{"format":"date-time","type":"string"},"StartDate":{"format":"date-time","type":"string"},"TerminationDate":{"format":"date-time","type":"string"},"TRAPetitionNumber":{"format":"int64","type":"integer"},"ID":{"format":"int64","type":"integer"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IClaimType":{"type":"object","properties":{"ID":{"format":"int32","type":"integer"},"Name":{"type":"string"}}},"IClaimWageRequest":{"type":"object","properties":{"AgencyID":{"format":"int64","type":"integer"},"BasePeriodTypeID":{"format":"int32","type":"integer"},"CityStateOfWorkLocation":{"type":"string"},"Claim":{"$ref":"#/definitions/IClaim"},"ClaimID":{"format":"int64","type":"integer"},"ClaimWageRequestStatusID":{"format":"int32","type":"integer"},"ClaimWageRequestTypeID":{"format":"int32","type":"integer"},"ClearDate":{"format":"date-time","type":"string"},"ClearNotes":{"type":"string"},"EmployeesDoingSameWorkCount":{"format":"int32","type":"integer"},"EmployerAccountNumber":{"type":"string"},"EmployerCoverageTypeID":{"format":"int32","type":"integer"},"HiringPersonName":{"type":"string"},"ImmediateSupervisorName":{"type":"string"},"IncorrectSocialSecurityNumber":{"type":"string"},"IsAffidavidWageRequested":{"type":"boolean"},"IsProofOfWagesProvided":{"type":"boolean"},"IsResolved":{"type":"boolean"},"IsWageAndHourFiledAgainstEmployer":{"type":"boolean"},"JobDuties":{"type":"string"},"LastDayWorked":{"format":"date-time","type":"string"},"LastDutyStation":{"type":"string"},"LocationOfEmployerRecords":{"type":"string"},"ManualEmployerName":{"type":"string"},"Note":{"type":"string"},"OriginalHireDate":{"format":"date-time","type":"string"},"OtherClaimantNames":{"type":"string"},"PayingEntity":{"type":"string"},"StartDate":{"format":"date-time","type":"string"},"TotalEmployees":{"format":"int32","type":"integer"},"ID":{"format":"int64","type":"integer"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IBasePeriodType":{"type":"object","properties":{"OrderBy":{"format":"int32","type":"integer"},"ID":{"format":"int32","type":"integer"},"Name":{"type":"string"}}},"IMonetaryType":{"type":"object","properties":{"ID":{"format":"int32","type":"integer"},"Name":{"type":"string"}}},"IClaimDeductionFrequencyType":{"type":"object","properties":{"OrderBy":{"format":"int32","type":"integer"},"ID":{"format":"int32","type":"integer"},"Name":{"type":"string"}}},"IClaimDeductionType":{"type":"object","properties":{"ID":{"format":"int32","type":"integer"},"Name":{"type":"string"}}},"IClaimExtensionMonetary":{"type":"object","properties":{"ClaimExtension":{"$ref":"#/definitions/IClaimExtension"},"ClaimExtensionID":{"format":"int64","type":"integer"},"ClaimExtensionMonetaryIncreases":{"type":"array","items":{"$ref":"#/definitions/IClaimExtensionMonetaryIncrease"}},"CurrentMonetaryIncrease":{"$ref":"#/definitions/IClaimExtensionMonetaryIncrease","readOnly":true},"IsCurrent":{"type":"boolean"},"IsLowMonetaryCalculated":{"type":"boolean","readOnly":true},"IsMailingRequired":{"type":"boolean"},"IsPending":{"type":"boolean"},"LowTotalBenefitAmount":{"format":"double","type":"number"},"MailedDate":{"format":"date-time","type":"string"},"MonetaryStatus":{"format":"int32","type":"integer","readOnly":true},"MonetaryType":{"$ref":"#/definitions/IMonetaryType"},"MonetaryTypeID":{"format":"int32","type":"integer"},"SequesterAmount":{"format":"double","type":"number"},"TotalBenefitAmount":{"format":"double","type":"number"},"ID":{"format":"int64","type":"integer"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IClaimExtensionReduction":{"type":"object","properties":{"ClaimExtensionID":{"format":"int64","type":"integer"},"ClaimExtension":{"$ref":"#/definitions/IClaimExtension"},"ReductionAmount":{"format":"double","type":"number"},"ReductionProgramType":{"$ref":"#/definitions/IReductionProgramType"},"ReductionProgramTypeID":{"format":"int64","type":"integer"},"ID":{"format":"int64","type":"integer"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IClaimExtensionMonetaryIncrease":{"type":"object","properties":{"ClaimExtensionMonetary":{"$ref":"#/definitions/IClaimExtensionMonetary"},"ClaimExtensionMonetaryID":{"format":"int64","type":"integer"},"ExtensionOccurenceIncrease":{"$ref":"#/definitions/IExtensionOccurenceIncrease"},"ExtensionOccurrenceIncreaseID":{"format":"int64","type":"integer"},"IncreasePercent":{"format":"double","type":"number"},"IncreaseWeeks":{"format":"int32","type":"integer"},"LowTotalBenefitAmount":{"format":"double","type":"number"},"StartDate":{"format":"date-time","type":"string"},"TotalBenefitAmount":{"format":"double","type":"number"},"ID":{"format":"int64","type":"integer"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IReductionProgramType":{"type":"object","properties":{"Description":{"type":"string"},"ID":{"format":"int32","type":"integer"},"Name":{"type":"string"}}},"IExtensionOccurenceIncrease":{"type":"object","properties":{"ExtensionOccurence":{"$ref":"#/definitions/IExtensionOccurence"},"ExtensionOccurrenceID":{"format":"int64","type":"integer"},"IncreasePercent":{"format":"double","type":"number"},"IncreaseWeeks":{"format":"int32","type":"integer"},"StartDate":{"format":"date-time","type":"string"},"ID":{"format":"int64","type":"integer"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IExtensionOccurence":{"type":"object","properties":{"AdditionalWeeksToFile":{"format":"int32","type":"integer"},"AlternateEarningDeductionMultiplier":{"format":"double","type":"number"},"AutoQualifyingDescription":{"type":"string"},"AutoQualifyingEntitlementWeeks":{"format":"int32","type":"integer"},"EndPetitionNumber":{"format":"int32","type":"integer"},"ExtensionBenefitType":{"$ref":"#/definitions/IExtensionBenefitType"},"ExtensionBenefitTypeID":{"format":"int32","type":"integer"},"ExtensionEndType":{"$ref":"#/definitions/IExtensionEndType"},"ExtensionEndTypeID":{"format":"int32","type":"integer"},"IsAlternateWeeklyBenefitAmountAllowed":{"type":"boolean"},"IsApprovedTraining":{"type":"boolean"},"IsAutoFilingEnabled":{"type":"boolean"},"IsClaimantFilingEnabled":{"type":"boolean"},"IsEndedByEligibleEntitlement":{"type":"boolean"},"IsParentExhaustionOrExpirationRequired":{"type":"boolean"},"IsParentExhaustionRequired":{"type":"boolean"},"IsRemainingTotalBenefitAmountAllowed":{"type":"boolean"},"IsSplitProgramPaymentsEnabled":{"type":"boolean"},"LastWeekIssueTypeID":{"format":"int32","type":"integer"},"MaximumStartDate":{"format":"date-time","type":"string"},"MaxPreviousBenefitYearEndDate":{"format":"date-time","type":"string"},"MinimumStartDate":{"format":"date-time","type":"string"},"MinTotalBenefitAmountDifferencePercent":{"format":"double","type":"number"},"MinWeeklyBenefitAmountDifference":{"format":"int32","type":"integer"},"ParentProgramType":{"$ref":"#/definitions/IProgramType"},"ParentProgramTypeID":{"format":"int32","type":"integer"},"PaymentEndDate":{"format":"date-time","type":"string"},"PaymentStartDate":{"format":"date-time","type":"string"},"ProgramType":{"$ref":"#/definitions/IProgramType"},"ProgramTypeID":{"format":"int32","type":"integer"},"QualifyingBenefitYearEnd":{"format":"date-time","type":"string"},"QualifyingEarningsWBAMultiplier":{"format":"int32","type":"integer"},"QualifyingEntitlementWeeks":{"format":"int32","type":"integer"},"StartPetitionNumber":{"format":"int32","type":"integer"},"TotalBenefitAmountPercent":{"format":"double","type":"number"},"WaiverCertificationWeeks":{"format":"int32","type":"integer"},"WaiverSeparationWeeks":{"format":"int32","type":"integer"},"WeeklyBenefitAmountMultiplier":{"format":"int32","type":"integer"},"ID":{"format":"int64","type":"integer"},"CreatedByUserID":{"format":"int64","type":"integer"},"CreatedDate":{"format":"date-time","type":"string"},"ModifiedByUserID":{"format":"int64","type":"integer"},"ModifiedDate":{"format":"date-time","type":"string"}}},"IExtensionBenefitType":{"type":"object","properties":{"Description":{"type":"string"},"IsTotalBenefitAmountPercentRequired":{"type":"boolean"},"IsWeeklyBenefitAmountMultiplierRequired":{"type":"boolean"},"ID":{"format":"int32","type":"integer"},"Name":{"type":"string"}}},"IExtensionEndType":{"type":"object","properties":{"Description":{"type":"string"},"IsSeparationDateRequired":{"type":"boolean"},"ID":{"format":"int32","type":"integer"},"Name":{"type":"string"}}}},"securityDefinitions":{}}

On Mon, May 16, 2016 at 7:09 PM, Sagan Marketing Support <
support@saganmarketing.com> wrote:

Sure. I've written a script that adds an IType (or whatever Type happens
to be)to each of the genned classes. The problem is that because those
properties are nullable, the compiler throws an error because "interface is
not implemented". So, instead of being able to use the genned class as the
concrete implementation for my IType interface, I have to go back and
remove all of these nullables first. I am dealing with some complex objects
here, so in my case I have over 260 errors to fix! This will not work if I
have to fix them each time I re-gen the classes.

On Mon, May 16, 2016, 6:24 PM Kyle Brooks notifications@github.com
wrote:

What does your swagger.json look like?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2885 (comment)

Thank you,
Sergey Sagan
http://www.saganmarketing.com
(208) 863-7451

*This acceptance is expressly made conditional on offeror's assent to all
additional or different terms contained herein. Should offeror not give
assent to said terms, there is no contract between the parties.

[Jabronironi]

Quick question. What is the reasoning for these being converted to nullable types? Is it the assumption @serjster made? It does seem odd to have to specify required, when the language already indicates if something is nullable or not.

[wing328]

The mapping between swagger type and C# type is here: https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/AbstractCSharpCodegen.java#L105

For method parameters that are required in swagger spec, C# API client will include a validation to ensure the parameter is not set to null.

For properties that are required, the model constructor will include a check on those.

In Swagger spec, currently there's no field in particular to make a parameter/property nullable.(of course one can use vendor extension to annotate that)

Regarding the question why we use nullable C# type for mapping, if my memory serves me well, it was mapped to nullable type before I started working on this project and I can't recall discussion about the design decision made regarding this.

If there's demand to use non-nullable type, we can definitely consider that and we would welcome contribution to make a CLI option to output non-nullable type when generating the C# API client.

If anyone has further question about nullable type in C# API client, please let me know and I'll try my best to answer.

[jimschubert]

required boolean Determines whether this parameter is mandatory. If the parameter is in "path", this property is required and its value MUST be true. Otherwise, the property MAY be included and its default value is false.

Suppose your API has a request input type:

{
  "id": "integer",
  "name": "String",
  "age": "integer"
}

If age is not a required property (required default is false), that means the following input is acceptable:

{
  "id": "integer",
  "name": "String"
}

If your type is defined as:

public class RequestInput {
    public int Id { get; set; }
    public String Name { get; set; }
    public int Age { get; set; }
}

The serializer's default functionality is to throw an exception. The serializer could be configured to set Age equal to 0. But what if your requirements for undefined Age values is -1 or 99 and your UI follows this rule almost everywhere? The serializer configuration assumption doesn't make sense. Why would you set a value if one wasn't provided? I use this example, because most people read -1 and 99 and think "Oh, that's silly. You should never use magic numbers when a value isn't provided." That's exactly what 0 is in this case-- a valid integer that the serializer would just be using as a marker value (for the first 11 months of my son's life he was 0 years old).

If your class is defined like this:

public class RequestInput {
    public int Id { get; set; }
    public String Name { get; set; }
    public int? Age { get; set; }
}

There's no assumptions that need to be made by the serializer. If your swagger definition hasn't explicitly set Age as a required property and someone makes a request without that property, your client and server code with a nullable integer will function intuitively.

You should be able to get around some of this by specifying a "default": 0 on your property. In this case, you'd have an integer that can never be null or undefined (it will default to 0). And this is the case defined by the spec that the question assumes should be the default behavior.

[SergeySagan]

This seems unnecessary. If Age was not a required property then I should make it nullable on the server and this should be enough for the serializer to do its thing. You are asking me to mix concerns here. My server side objects should be agnostic of my swagger needs. If I was to avoid mixing concerns, then you're asking me to manually create POCO's specifically for swagger on the server side to make this work. Perhaps I am still missing something, but I do not see the reason for making my non-nullable properties as nullable. If I am on the server side and I, very unnaturally, need to make one of my properties as nullable just for the api, then I should be forced to make a POCO for this on the server. Instead you are making everybody else suffer for something that will likely never be needed.

[jimschubert]

My response was to @RemyArmstro. Sorry for not clarifying.

To your point, it seems like your classes are generating this way because your properties aren't marked required. The swagger definition defaulting properties to default=false makes sense for many languages. It seems like it's just unexpected in your case. You should only need to change the swagger definition to generate code as expected.

Are you creating your swagger definition manually, or are you generating against server code using something like Swashbuckle? For Swashbuckle, you can apply a filter to the ApiExplorer the framework uses to generate the swagger definition and mark primitives as required. It may even have a configuration for this, it's been a few months since i last looked at that project.

[gitfool]

👍 I'm also very interested in this discussion.

I'm using Swashbuckle in the C# server to generate the Swagger doc, then feeding that into AutoRest to generate the C# proxy. IMHO primitives (and arrays of primitives) are not being generated as expected, at least not without jumping through a lot of hoops; far from the pit of success I expected by default.

That is, if I created the proxy by hand, it would obviously have exactly the same C# types as used on the server: especially important is that non-nullable primitives should stay non-nullable, and of course nullable primitives should stay nullable too! Throw in arrays of non-nullables, arrays of nullables, enums, and guids, and it gets even more 'interesting'.

C# type semantics should be preserved between client / proxy and server, and right now the tooling is making that very difficult.

Have a look at OpenAPI-Specification issue #229 for related discussions.