Swagger generates invalid Angular 2 typescript

[webron]

From @bendg25 on July 20, 2016 8:17

Given an Integer pageNumber on a java Rest controller, Swagger generates:

public getAllTemplatesUsingGET (pageNumber: number, pageSize: number,

    if (pageNumber !== undefined) {
        queryParameters.set('pageNumber', pageNumber);
    }

Error (Webstorm): TS2345: Argument of type 'number' is not assignable to parameter of type 'string'

Copied from original issue: swagger-api/swagger-editor#1014

[wing328]

@bendg25 if we change the code as follows, would that resolve the issue?

    if (pageNumber !== undefined) {
        queryParameters.set('pageNumber', String(pageNumber));
    }

cc @Vrolijkx

[bendg25]

Yes this would resolve the issue. (code above compiles)

Thanks

On 21 July 2016 at 05:34, wing328 notifications@github.com wrote:

@bendg25 https://github.com/bendg25 if we change the code as follows,
would that resolve the issue?

if (pageNumber !== undefined) {
    queryParameters.set('pageNumber', String(pageNumber));
}

cc @Vrolijkx https://github.com/Vrolijkx

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3427 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEGmXQKa8jttgh43vy0IvMSNbuq9t3zSks5qXvbMgaJpZM4JRAKa
.

Ben Gill
Mobile: (07852) 219856
E-mail: ben.d.gill@gmail.com

[wing328]

@bendg25 fixed with #3431. Please pull the latest master of swagger-codegen to give it a try.

[bendg25]

I am running it from editor.swagger

On 21 July 2016 at 10:44, wing328 notifications@github.com wrote:

@bendg25 https://github.com/bendg25 fixed with #3431
#3431. Please pull
the latest master of swagger-codegen to give it a try.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3427 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEGmXbHFAEPQ_pRbSE_nJxG4pe-dyZFgks5qXz-MgaJpZM4JRAKa
.

Ben Gill
Mobile: (07852) 219856
E-mail: ben.d.gill@gmail.com

[wing328]

To use the latest version with the fix, you will need to build the JAR locally.

[bendg25]

1: I get errors when I try to use generated code from swagger-codegen. It
seems to generate different code to the online editor.

2: One other point too, you generate interfaces, but it is not that clear
to me how to use the Typescript interfaces when newing them up.

http://stackoverflow.com/questions/13142635/how-can-i-create-an-object-based-on-an-interface-file-definition-in-typescript

I wonder whether you could generate the classes either a) instead or b) as
well.

3: Some of the generated code loses its inheritance relationship.

I can try and produce samples to demonstrate problems.

On 21 July 2016 at 10:51, wing328 notifications@github.com wrote:

To use the latest version with the fix, you will need to build the JAR
locally.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3427 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEGmXf29Tac9HvA7OzVgJrmm7SAI902Tks5qX0E1gaJpZM4JRAKa
.

Ben Gill
Mobile: (07852) 219856
E-mail: ben.d.gill@gmail.com

[bendg25]

1. In the handling of responses from POST's etc.. not all will return data
   so generated client needs to do this:

In extractData:

private extractData(res: Response) {
let body;

// check if empty, before call json
if (res.text()) {
    body = res.json();
}

return body || {};}

else if results in js error 'unexpected end of pipe' type error

On 26 July 2016 at 07:44, Ben Gill ben.d.gill@gmail.com wrote:

1: I get errors when I try to use generated code from swagger-codegen. It
seems to generate different code to the online editor.

2: One other point too, you generate interfaces, but it is not that clear
to me how to use the Typescript interfaces when newing them up.

http://stackoverflow.com/questions/13142635/how-can-i-create-an-object-based-on-an-interface-file-definition-in-typescript

I wonder whether you could generate the classes either a) instead or b) as
well.

3: Some of the generated code loses its inheritance relationship.

I can try and produce samples to demonstrate problems.

On 21 July 2016 at 10:51, wing328 notifications@github.com wrote:

To use the latest version with the fix, you will need to build the JAR
locally.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3427 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEGmXf29Tac9HvA7OzVgJrmm7SAI902Tks5qX0E1gaJpZM4JRAKa
.

Ben Gill
Mobile: (07852) 219856
E-mail: ben.d.gill@gmail.com

Ben Gill
Mobile: (07852) 219856
E-mail: ben.d.gill@gmail.com