[Spring] compilation issue - query params enumerations

[rajeshkamal5050]

When you an enumeration of supported/valid strings specified for the query parameter in the spec

"parameters":[
   {
      "name":"acmeStatus",
      "in":"query",
      "description":"Status of Acme's you want to retrieve.",
      "required":true,
      "type":"string",
      "enum":[
         "SUCCESS",
         "FAILED",
         "INPROGRESS"
      ]
   }
]

The generated spring code - Controller Interface code does not compile. The @ApiParam's allowableValues(String) property gets generated and it has some issues

allowableValues = "{values=[SUCCESS, FAILED, INPROGRESS], enumVars=[{name=SUCCESS, value="SUCCESS"}, {name=FAILED, value="FAILED"}, {name=INPROGRESS, value="INPROGRESS"}]}"

Complete Controller Method

    @ApiOperation(value = "Query Acme's by status", notes = "Get the list of Acme's for the provided Acme status", response = Acme.class, responseContainer = "List", tags={ "AcmeService", })
    @ApiResponses(value = { 
        @ApiResponse(code = 200, message = "OK", response = Acme.class) })
    @RequestMapping(value = "/acmes",
        produces = { "application/json" }, 
        method = RequestMethod.GET)
    ResponseEntity<List<Acme>> getAcmesByStatus(@ApiParam(value = "Status of Acme's you want to retrieve.", required = true, allowableValues = "{values=[SUCCESS, FAILED, INPROGRESS], enumVars=[{name=SUCCESS, value="SUCCESS"}, {name=FAILED, value="FAILED"}, {name=INPROGRESS, value="INPROGRESS"}]}") @RequestParam(value = "acmeStatus", required = true) String acmeStatus



);

[stevecookform3]

For the example enum:

        type: string
        enum:
         - CSV
         - XML
         - TXT

In jaxrs you get

allowableValues="CSV, XML, TXT"

in spring you get

allowableValues = "{values=[CSV, XML, TXT], enumVars=[{name=CSV, value="CSV"}, {name=XML, value="XML"}, {name=TXT, value="TXT"}]}")

My assumption is that the jaxrs version is the correct one.

[wing328]

@stevecookform3 thanks for the additional info. I'll take a look later today or tomorrow.

[wing328]

@Rajeshkamal @stevecookform3 It seems to me the issue should have been fixed in the latest master and we've a test case to cover it. Here is the auto-generated code for the test case:

swagger-codegen/samples/server/petstore/spring-mvc/src/main/java/io/swagger/api/FakeApiController.java

Line 120 in 4e20bd9

@ApiParam(value = "Query parameter enum test (string array)", allowableValues = "GREATER_THAN, DOLLAR") @RequestParam(value = "enumQueryStringArray", required = false) List<String> enumQueryStringArray

Have you pull the latest master to generate spring boot/mvc server stub?

[stevecookform3]

Yes - looks good in latest master. thanks.

[wing328]

@stevecookform3 thanks for the confirmation. Issue closed.