spring-mvc path enum generated code fails to compile

[mikee]

Description

Generate code with an enum string path param and the generated spring-mvc code will not compile due to the way the generated enum values are quoted

Failing generated code - note the quoted values inside the allowableValues quote:
public ResponseEntity<Void> demoGet(@ApiParam(value = "day of the week",required=true, allowableValues="{values=[Monday, Tuesday, Wednesday, Thursday, Friday, Saturday, Sunday], enumVars=[{name=MONDAY, value="Monday"}, {name=TUESDAY, value="Tuesday"}, {name=WEDNESDAY, value="Wednesday"}, {name=THURSDAY, value="Thursday"}, {name=FRIDAY, value="Friday"}, {name=SATURDAY, value="Saturday"}, {name=SUNDAY, value="Sunday"}]}" ) @PathVariable("day") String day) { // do some magic! return new ResponseEntity<Void>(HttpStatus.OK); }

Swagger-codegen version

2.2.2-SNAPSHOT (master) - tried also with 2.2.1

Swagger declaration file content or url

Sample failing yaml

    #YAML Demonstration
swagger: '2.0'
info:
  title: Demonstration of Swagger Yaml with Enumeration
  description: Simple Demonstration of Enumeration
  version: "1.0.0"
host: api.bastide.org
schemes:
  - https
basePath: /1/{day}
produces:
  - application/atom+xml
paths:
  /demo:
    get:
      summary: demonstration for enumeration
      description: |
        Demonstrates an enumeration
      parameters:
        - name: day
          in: path
          description: day of the week
          required: true
          type: string
          enum:
            - Monday
            - Tuesday
            - Wednesday 
            - Thursday
            - Friday
            - Saturday
            - Sunday
      responses:
        200:
          description: The response upon succesful query
        default:
          description: Error occured 

If you switch back to query param type the generated code is fine.

Command line used for generation

java -jar modules/swagger-codegen-cli/target/swagger-codegen-cli.jar generate -i ./test.yaml -l spring -o samples/server/example/spring-mvc

Steps to reproduce

Use the sample yaml above saved as test.yml.
Run the code gen command line above
cd to samples/server/example/spring-mvc
run mvn compile
Look at the DemoApiController.java to see the issue.

Related issues

Similar area to #4550 perhaps?

Suggest a Fix

Will update if I can work something out

[mikee]

I've worked around this locally by effectively merging the get param mustache template into the path params template. I'm not sure that this solution is technically correct - but it seems to work for now

New Template: modules/swagger-codegen/src/main/resources/JavaSpring/pathParams.mustache
{{#isPathParam}}{{#useBeanValidation}}{{>beanValidationPathParams}}{{/useBeanValidation}}@ApiParam(value = "{{{description}}}"{{#required}},required=true{{/required}}{{#allowableValues}}, allowableValues = "{{#enumVars}}{{{name}}}{{^-last}}, {{/-last}}{{#-last}}{{/-last}}{{/enumVars}}"{{/allowableValues}} {{#defaultValue}}, defaultValue="{{{defaultValue}}}"{{/defaultValue}}) @PathVariable("{{paramName}}") {{{dataType}}} {{paramName}}{{/isPathParam}}

[wing328]

@mikee thanks Mike. Do you mind submitting a PR so that the credit goes back to you?

[liebig]

What is the status of this? I have the same issue and need the fix. @mikee did you create a PR?

Edit: I updated from 2.2.1 to 2.2.2 and now it seems to work fine.

[wing328]

@liebig the issue may have been resolved.

Can you also try the latest master as well?

[liebig]

I tested on the latest master and it seems to work fine.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] swagger-codegen-project ............................ SUCCESS [  1.987 s]
[INFO] swagger-codegen (core library) ..................... SUCCESS [ 26.336 s]
[INFO] swagger-codegen (executable) ....................... SUCCESS [  5.398 s]
[INFO] swagger-codegen (maven-plugin) ..................... SUCCESS [  3.097 s]
[INFO] swagger-generator .................................. SUCCESS [ 35.338 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:12 min
[INFO] Finished at: 2017-04-27T13:39:06+02:00
[INFO] Final Memory: 79M/1130M
[INFO] ------------------------------------------------------------------------

[wing328]

@liebig thanks for doing a test. Closing this.