[java-play-framework] Error building the project when config parameters are overridden

[sashank]

Description

We generated the Source code from swagger.yaml , we also have config.json that overrides certain parameters (mentioned below) , When we try to build the code it fails due to overridden params are not reflecting in "Module.java"

Swagger-codegen version

2.3.0

Swagger declaration file content or url

can try with any swagger file (say petstore.yaml)

Command line used for generation

java -jar swagger-codegen-2.3.0 jar -i petstore.yaml -c config.json -l java-play-framework

in config.json add below line to override
"apiPackage":"com.puppies.store.apis",

Steps to reproduce

This generates the code , when we build it fails , the cause is because
in which Module.java has still older statement

import controllers.*;

ideally , since we overridden "apiPackage" it should be
import com.puppies.store.apis.*;

once we changed this manually , we could build it fine .
so ideally code generator need to be fixed !

Related issues/PRs

Suggest a fix/enhancement

[wing328]

@sashank thanks for reporting the issue. May I know if you've time to contribute a fix?

A good starting point is https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/resources/JavaPlayFramework/module.mustache

and you can try to fix the issue with {{pacakge}} (https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/resources/JavaPlayFramework/newApi.mustache#L1)

[sashank]

am sorry , am totally maxed out ! not sure if i can fix this .

[wing328]

No worry. I'll give it a try over the weekend.

[sashank]

Ok identified a related issue,, the routes file also needs to be fixed , it still has controllers.* although we overridden it to "com.puppies.store" , please fix this issue as well

[wing328]

I might need to postpone it to coming Tuesday instead as I've another busy weekend...

[wing328]

Sorry. I'll leave it to the community to help out on this as I'm busy with too many things at the moment.

[JFCote]

Hi @sashank , I'm the main contributor to the Play Framework Generator. @wing328 didn't tag me on this so I wasn't aware.

I will try to look into this next week. I wasn't aware that this option existed at all. That explains why the generator is not taking care of it. I'll keep you posted here.

[wing328]

@JFCote sorry I forgot to tag you :(

[JFCote]

@wing328 No problem man! I'll look into this next week or the one after. I'm currently in a rush at work.

[shauncarlson]

I'm seeing an issue when I try to generate java client with any library other than the default (okhttp-gson) specified. It is not generating some basic files (ApiCallback, ApiException, ApiResponse, among others), and the files it does generate do not seem to be using the mustache files under the library's directory. I'm interested in building using retrofit2, but this is not working, no matter which way I try. Is this related to the error reported here?

• using 2.2.2, though seeing same behavior in 2.2.3

[JFCote]

Oh it's been a crazy month. I didn't had time to look into this and I don't think I will have time before christmas. Sorry about the delay @sashank.

As for @shauncarlson , I don't think what you are tallking about is related to the bug report. Maybe you can create a new bug for this? Thanks!