[maven plugin] Use configurator for maven plugin#2168
Merged
wing328 merged 2 commits intoswagger-api:masterfrom Mar 1, 2016
Merged
[maven plugin] Use configurator for maven plugin#2168wing328 merged 2 commits intoswagger-api:masterfrom
wing328 merged 2 commits intoswagger-api:masterfrom
Conversation
Contributor
<configOptions>
<additional-properties>optionalProjectFile=true</additional-properties>
</configOptions>I guess this is out of scope for this pull request, but I think that additional-properties should be of type Map, not string, and thus allow structured entry: <configOptions>
<additional-properties>
<optionalProjectFile>true</optionalProjectFile>
</additional-properties>
</configOptions>I'm not sure how one could do a transition supporting both old and new form, though. |
ePaul
pushed a commit
to ePaul/swagger-codegen
that referenced
this pull request
Feb 22, 2016
This implements the command line arguments `--model-name-prefix` and `--model-name-suffix` for all languages which do not override `DefaultCodegen.toModelName()`. This fixes most of swagger-api#1255. Connection to the maven plugin works with additional-properties, a more explicit parameter waits for swagger-api#2168.
| * to specific settings in CodegenConfigurator. | ||
| * | ||
| * <p> | ||
| * This class exists to facility in testing. These methods could be applied |
Contributor
Author
There was a problem hiding this comment.
Thanks. Must've been muscle memory from the day job.
ePaul
pushed a commit
to ePaul/swagger-codegen
that referenced
this pull request
Feb 26, 2016
This implements the command line arguments `--model-name-prefix` and `--model-name-suffix` for all languages which do not override `DefaultCodegen.toModelName()`. This fixes most of swagger-api#1255. Connection to the maven plugin works with additional-properties, a more explicit parameter waits for swagger-api#2168.
wing328
added a commit
that referenced
this pull request
Mar 1, 2016
[maven plugin] Use configurator for maven plugin
jpedroh
pushed a commit
to jpedroh/mining-framework-analysis
that referenced
this pull request
Mar 21, 2025
This implements the command line arguments `--model-name-prefix` and `--model-name-suffix` for all languages which do not override `DefaultCodegen.toModelName()`. This fixes most of swagger-api/swagger-codegen#1255. Connection to the maven plugin works with additional-properties, a more explicit parameter waits for swagger-api/swagger-codegen#2168.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #2104
This reduces code duplication between CLI and maven-plugin.
The maven plugin can now support more options like
language-specific-primitivesandadditional-properties.Here's an example configuration to demonstrate passing
additional-properties: