Skip to content

Typescript fetch update#2791

Merged
wing328 merged 2 commits intoswagger-api:masterfrom
leonyu:typescript-fetch-package-json
May 9, 2016
Merged

Typescript fetch update#2791
wing328 merged 2 commits intoswagger-api:masterfrom
leonyu:typescript-fetch-package-json

Conversation

@leonyu
Copy link
Copy Markdown
Contributor

@leonyu leonyu commented May 6, 2016

  • Add npmName and npmVersion
    • will take a look at npmRepository and snapshot since my use case doesn't take advantage of those
  • Make sure compilable in both ES6 and ES5
  • Fix enum implementation (was broken in the PetStore)
    • this implementation uses string literals for string enums instead of Enum (maybe this would be better served as an option) since TypeScript Enum follows C Enum instead of Java Enum that defaults to a number. see ref

Leon Yu added 2 commits May 6, 2016 15:59
@wing328 wing328 added this to the v2.2.0 milestone May 7, 2016
@wing328 wing328 merged commit e367a74 into swagger-api:master May 9, 2016
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented May 9, 2016

@leonyu thanks for the contribution. PR merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants