[Swift] Add sample/tests for Swift client without PromiseKit#2931
Merged
wing328 merged 1 commit intoswagger-api:masterfrom May 21, 2016
Merged
[Swift] Add sample/tests for Swift client without PromiseKit#2931wing328 merged 1 commit intoswagger-api:masterfrom
wing328 merged 1 commit intoswagger-api:masterfrom
Conversation
Contributor
|
+1 looks good |
wing328
added
Client: Swift
Enhancement: Feature
Enhancement: General
and removed
Enhancement: Feature
labels
Contributor
|
Thanks both! PR merged. |
Contributor
Author
|
Thanks! |
Contributor
|
hey btw one minor thing I noticed - java/android and other client samples are structured this way: should we move swift to the same structure - i.e.: |
Contributor
Author
Contributor
|
@wing328 I feel like it would be more straightforward to go w/ samples/client/petstore/language/language_derivation and move javascript/typescript and I believe scala (akka-scala,async-scala,etc..) into this pattern... up to you I'm fine either way as well. |
Contributor
|
Both are fine. My preference is the suggestion by @jaz-ah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sample/tests for Swift client without PromiseKit. Also moved the tests with PromiseKit to swift-promisekit (as without is the default config).
cc: @jaz-ah