Skip to content

update package.json and fix webpack.html#2973

Merged
wing328 merged 1 commit intoswagger-api:masterfrom
leonyu:update_tsify
May 26, 2016
Merged

update package.json and fix webpack.html#2973
wing328 merged 1 commit intoswagger-api:masterfrom
leonyu:update_tsify

Conversation

@leonyu
Copy link
Copy Markdown
Contributor

@leonyu leonyu commented May 26, 2016

  • Update tsify
  • Fix webpack.html file

@leonyu
Copy link
Copy Markdown
Contributor Author

leonyu commented May 26, 2016

The version of tsify appeared to be the problem with CI. This PR updates it to latest. tsify is not required by the codegen, only by browserify TypeScript users (which the test was written in).

It might be beneficial to pin the NPM package versions for both the test and codegen so CI doesn't randomly fail when dependent packages update. There are at least two methods for pinning, I will need to investigate a bit on which one to use for this.

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented May 26, 2016

@leonyu thanks for the fix. I'll review and merge later today.

@wing328 wing328 added this to the v2.2.0 milestone May 26, 2016
@wing328 wing328 merged commit d8dec24 into swagger-api:master May 26, 2016
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented May 26, 2016

@leonyu that works. I've included TS Fetch API clients in the CI via #2976.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants