[Typescript-Node] Add Support for useQuerystring Request Option #2905#2989
Merged
wing328 merged 6 commits intoswagger-api:masterfrom May 29, 2016
Merged
[Typescript-Node] Add Support for useQuerystring Request Option #2905#2989wing328 merged 6 commits intoswagger-api:masterfrom
wing328 merged 6 commits intoswagger-api:masterfrom
Conversation
added 6 commits
May 29, 2016 01:29
…clude rather than files. Add gitignore for output files.
…pes. Update client to not use finally since this doesn't exist on a node js Promise.
Contributor
Author
|
Test cases passed |
Contributor
|
The only thing here that might not have been necessary was replacing the finally() with a then() in the client.ts / test client. I was thrown off by the alias for bluebird being Promise. Native promises don't support finally (aka promises from the node/corejs typings), but bluebird does. Finally should have been ok to leave, but I can't remember if I resolved this or not in my PR. I originally removed it because of typing / build issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick based on #2905
credit: @pixelshaded