A quick fix to support 1 sub array like [[Object]]#3195
Open
faresd wants to merge 1 commit intoswagger-api:masterfrom
Open
A quick fix to support 1 sub array like [[Object]]#3195faresd wants to merge 1 commit intoswagger-api:masterfrom
faresd wants to merge 1 commit intoswagger-api:masterfrom
Conversation
|
|
||
| property.baseType = getSwaggerType(p); | ||
|
|
||
| // A quick fix to support 1 sub array like [[Object]] |
Contributor
There was a problem hiding this comment.
I think this comment, if necessary, should be above your ~7 line addition and not above the entire block for ArrayProperty.
Contributor
|
@faresd thanks for the PR. I believe your fix only handle 1D and 2D arrays. Ideally we are looking for a recursive way to support arrays of any dimensions. |
Author
|
@wing328 I don't think I will have the time implement the recursion. |
Contributor
|
@faresd thats ok. We appreciate your contribution and will merge this PR after 2.2.0 issue if no question from anyone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request following ticket #3194, Imports don't support nested Arrays and Maps.