[MAVEN] #3284: Made modelNamePrefix and -Suffix available through maven#3289
Conversation
|
Looks nice. (I didn't test is yet.) Previously I just passed this argument through the |
|
Thanks. This wasn't successful for me: And because it is a parameter in the cli I thought it makes sense to put it there as well. If there is a way over the |
|
@d0x I think I used something like this (I don't have a project using this here right now): <configOptions>
<additionalProperties>modelNameSuffix=DTO</additionalProperties>
</configOptions>I actually prefer your way, I just was too lazy to build this in when adding the modelNameSuffix feature. |
| } | ||
|
|
||
| if(isNotEmpty(modelNameSuffix)) { | ||
| configurator.setModelNamePrefix(modelNameSuffix); |
There was a problem hiding this comment.
You have a copy+paste error here, this should be configurator.setModelNameSuffix(...).
|
With the fixed configurator call, it does what it pretends to do. So 👍 depending on fixing what I mentioned. Thankyou for the pull request, and sorry for taking so long to review it. |
|
I fixed the c&p error. Sorry for that. Have a nice sunday. |
|
👍 – can be merged from my point of view. |
As described in #3284