[PHP] add AbstractPhpCodegen to be as the base class of PHP-related generators#3310
Merged
wing328 merged 10 commits intoswagger-api:masterfrom Aug 1, 2016
Merged
[PHP] add AbstractPhpCodegen to be as the base class of PHP-related generators#3310wing328 merged 10 commits intoswagger-api:masterfrom
wing328 merged 10 commits intoswagger-api:masterfrom
Conversation
…tors so that the same enhancements or bug fixes can be applied to all clients. Most source be moved from the PhpClientCodegen.
…rverOptionsTest for unit test
Contributor
|
For #3227 |
Contributor
|
cc @arnested |
|
|
||
| // additionalProperties.put("escapedInvokerPackage", invokerPackage.replace("\\", "\\\\")); | ||
|
|
||
| // // make api and model doc path available in mustache template |
Contributor
There was a problem hiding this comment.
I think apiDocPath and modelDocPath are still used in PHP API client documentation (markdown) so we should keep it.
Contributor
|
@abcsun when you've time, can you help do a rebase on the latest master to resolve the merge conflicts? |
Contributor
Author
|
@wing328 please review |
Contributor
|
I did some tests with PHP API client, Slim, Silex, Lumen and found 1 issue. If I run the following command: it shows the following error:
@abcsun please let me know if you need help fixing the issue. |
Contributor
Author
|
@wing328 Forgot to set the templateDir in LumenServerCodegen, it has be fixed. |
Contributor
|
@abcsun thanks for the fix. It works for me now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.