[Java] Optional Parcelable models for okhttp-gson#3320
Closed
GriffinSchneider wants to merge 2 commits intoswagger-api:masterfrom
Closed
[Java] Optional Parcelable models for okhttp-gson#3320GriffinSchneider wants to merge 2 commits intoswagger-api:masterfrom
GriffinSchneider wants to merge 2 commits intoswagger-api:masterfrom
Conversation
…elableModel=true option is provided.
…odel are both true.
Contributor
|
@GriffinSchneider thanks for the PR. I did a test and got compile errors. I think you need to update pom.mustache, gradle.build.mustache and sbt.build.mustache to include the dependencies for |
| } | ||
| return o.toString().replace("\n", "\n "); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
It would be nice to add docstrings to the new methods (e.g. writeToParacel, describeContents).
Contributor
|
@GriffinSchneider do you need any help fixing the compilation error? |
3 tasks
Contributor
|
@GriffinSchneider thanks for the PR. Closing this as #3928 has been merged into master. (the credit will belong to you as the 2 commits are still owned by you) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #3302.
When generating with
-l java --library=okhttp-gson -DparcelableModel=true, generated model classes will now implement Android'sParcelableinterface.I essentially just copied how
useRxJavaworks to add the command line option and make the tests pass. Let me know if I should do anything differently and I'll be happy to make the change 👍.