[Go] ParameterToString can panic#3384
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Jul 18, 2016
keithballdotnet:patch-1
Merged
[Go] ParameterToString can panic#3384wing328 merged 1 commit intoswagger-api:masterfrom keithballdotnet:patch-1
wing328 merged 1 commit intoswagger-api:masterfrom
keithballdotnet:patch-1
Conversation
Let the fmt package help convert the obj to a string. Previously this could panic if the obj was an int.
keithballdotnet
changed the title
Contributor
|
@keithballdotnet thanks for the PR. |
Contributor
|
looks good! |
Contributor
|
@keithballdotnet thanks for the PR. Next time, please run @guohuang thanks for reviewing the PR. |
Contributor
Author
|
Sorry, @wing328 I just edited the file inline on github. Next time will do a full edit. ;) |
Contributor
|
@keithballdotnet no problem and we (the community) appreciate your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let the fmt package help convert the obj to a string. Previously this could panic if the obj was an int.