dart codegen improvements#3440
Merged
wing328 merged 13 commits intoswagger-api:masterfrom Jul 23, 2016
Merged
Conversation
don't assume query params are Strings or List<String>s
type is Iterable, not List only check params for != null if they haven't been checked already add some casts to make strong mode happy update petstore
move petstore client into subdirectory and reference generated libraries using path in pubspec.yaml
The new layout resembles a real project. petstore test is now strong mode compatible.
find pets by tag call is deprecated and returns 500 generated library is now strong mode compatible
Contributor
|
@close2 thanks for the PR ( 👍 to comments in the code and explanation of the change) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generated library has better exceptions, type conversion is better (/fixed), dart strong mode is enabled, petstore test is refactored and now looks like a real project (generated lib in a different directory) (this more or less closes #3334)
I have not split the test into 2 projects for browser and vm because dart will support creating libraries which support browser and vm at the same time soon.