Skip to content

[PHP] Client properties validation #3457#3480

Merged
wing328 merged 2 commits intoswagger-api:masterfrom
arnested:php/Client_properties_validation-3457
Aug 1, 2016
Merged

[PHP] Client properties validation #3457#3480
wing328 merged 2 commits intoswagger-api:masterfrom
arnested:php/Client_properties_validation-3457

Conversation

@arnested
Copy link
Copy Markdown
Contributor

Fixes #3457.

@arnested
Copy link
Copy Markdown
Contributor Author

Could use a test case testing this though.

@wing328 wing328 added this to the v2.2.1 milestone Aug 1, 2016
@wing328 wing328 merged commit 0f8e1f8 into swagger-api:master Aug 1, 2016
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Aug 1, 2016

linked to #2663

@arnested arnested deleted the php/Client_properties_validation-3457 branch August 1, 2016 07:28
@akira28
Copy link
Copy Markdown

akira28 commented Aug 1, 2016

@arnested Sorry to inform this is bugged :(
generated models have syntax errors like these:

if (!is_null(${{$this->container['id_compliance_scan']}}) && (strlen($this->container['id_compliance_scan']) < 36)) {
    $invalid_properties[] = "invalid value for 'id_compliance_scan', the character length must be bigger than or equal to 36.";
}

@arnested
Copy link
Copy Markdown
Contributor Author

arnested commented Aug 1, 2016

@akira28, you are right. Don't know how I managed to do that. And don't know how I managed not to catch that.

Fix ready in a few minutes.

@arnested
Copy link
Copy Markdown
Contributor Author

arnested commented Aug 1, 2016

See #3493 for the fix. Thanks for catching this, @akira28.

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Aug 1, 2016

@arnested thanks for the quick fix.

@akira28 please pull the latest master to give it another try.

@akira28
Copy link
Copy Markdown

akira28 commented Aug 1, 2016

I'll try it and let you know. Thanks for the quick fix!

@akira28
Copy link
Copy Markdown

akira28 commented Aug 1, 2016

@arnested @wing328 seems to work correctly now. Thank you very much

@arnested
Copy link
Copy Markdown
Contributor Author

arnested commented Aug 1, 2016

Thank you very much for reporting back, @akira28!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants