fixing bug of rendering an extra spaces into @FeignClient annotation#3487
fixing bug of rendering an extra spaces into @FeignClient annotation#3487wing328 merged 3 commits intoswagger-api:masterfrom
Conversation
|
Can you also regenerate the spring-cloud sample ? |
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors. Let me know if you need help fixing it. |
|
@szantopeter thanks for the feedback. We've documented Petstore sample update procedure here: https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md#testing but seems like not many people notice it. We'll probably create a PR template to draw people's attention about updating Petstore sample so that CIs can verify the change. |
|
@wing328 I think most people (users of SWAGGER) will not be as much interested in how to generate the samples, rather what options they need to specify to generate a client from their SWAGGER files using the same technologies. In some cases this is not so obvious because it is not just the language has to be set but also additional options, libraries, etc. Maybe it would worth adding this information to all samples (I only added it to two of them) By the way I read the how to contribute page, but it seems I missed the relevant part at the bottom... ;) |
FeignClient annotations are redered incorrectly with an extra space. This causes a problem that spring properties are not loaded. E.g: the below annotation was generated
@FeignClient(name="${ swaggerPetstoreSimple.name:swaggerPetstoreSimple}", url="${ swaggerPetstoreSimple.url:https://localhost:8080/api}", configuration = ClientConfiguration.class)and overwriting
swaggerPetstoreSimple.name:swaggerPetstoreSimple
was not possible because of the extra spaces.