Skip to content

NodeJS generator - Harken to the the warnings ...#3494

Merged
wing328 merged 1 commit intoswagger-api:masterfrom
osher:patch-1
Aug 1, 2016
Merged

NodeJS generator - Harken to the the warnings ...#3494
wing328 merged 1 commit intoswagger-api:masterfrom
osher:patch-1

Conversation

@osher
Copy link
Copy Markdown
Contributor

@osher osher commented Aug 1, 2016

2 types of warnings are emitted in bulk whenever using the nodeJS generator:

[main] WARN io.swagger.codegen.DefaultCodegen - escapeUnsafeCharacters should be overriden in the code generator with proper logic to escape unsafe characters

and

[main] WARN io.swagger.codegen.DefaultCodegen - escapeQuotationMark should be overriden in the code generator with proper logic to escape single/double quote

I did some guesswork: since JS is a c-type language like C# and Java - I looked there for reference, and followed their example.

2 types of warnings are emitted in bulk whenever using the nodeJS generator.

I did some guesswork: since JS is a c-type language like C# and Java - I looked there for reference, and followed their example.
@osher
Copy link
Copy Markdown
Contributor Author

osher commented Aug 1, 2016

uhhh....
how do I label it as Server: Nodejs ?

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Aug 1, 2016

@osher the change looks good to me. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants