Skip to content

[TS][Angular2] inject base_path opaque token#3514

Merged
wing328 merged 2 commits intoswagger-api:masterfrom
damienpontifex:typescript-angular2-baseurl-inject
Aug 22, 2016
Merged

[TS][Angular2] inject base_path opaque token#3514
wing328 merged 2 commits intoswagger-api:masterfrom
damienpontifex:typescript-angular2-baseurl-inject

Conversation

@damienpontifex
Copy link
Copy Markdown
Contributor

Enable setup of base path for apis in angular2 bootstrap by providing the value to resolve #3513

Need verifying I haven't missed anything as first code contribution to swagger-codegen and building the project from source

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Aug 3, 2016

@damienpontifex thanks for the PR.

cc @Vrolijkx

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Aug 3, 2016

@damienpontifex is it correct to say that this is a breaking change (non-backward compatible)?

If yes, please re-submit the PR for 2.1.3 branch instead.

@damienpontifex
Copy link
Copy Markdown
Contributor Author

@wing328 I don't believe it to be a breaking change as it just provides another avenue for passing in the configuration value.
I would be happy to have more feedback from others who are using it if it is actually causing a breaking change.

@Vrolijkx
Copy link
Copy Markdown
Contributor

Vrolijkx commented Aug 4, 2016

Nice addition to the angular2 api. Doesn't seem a breaking change to me. should be completely backward compatible.

@damienpontifex
Copy link
Copy Markdown
Contributor Author

@wing328 @Vrolijkx just quickly added a note in the readme of how to set the custom base path. Let me know if there is any other sort of documentation we would normally add to these.

@wing328 wing328 modified the milestones: v2.2.1, v2.3.0 Aug 8, 2016
@martinmcwhorter
Copy link
Copy Markdown
Contributor

I just ran into this missing OpaqueToken issue today. Im glad to see there is a pull request and hopefully this will be be in a release soon enough.

@wing328 wing328 merged commit 54fe7a7 into swagger-api:master Aug 22, 2016
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Aug 22, 2016

@damienpontifex thanks for the PR, which has been merged into master.

@wing328 wing328 modified the milestones: v2.2.2, v2.3.0 Sep 21, 2016
@damienpontifex damienpontifex deleted the typescript-angular2-baseurl-inject branch January 22, 2017 23:51
@wing328 wing328 changed the title inject base_path opaque token for typescript angular2 [TS][Angular2] inject base_path opaque token Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[typescript-angular2] baseUrl injectable

4 participants