[aspnet] Honor casing of properties from definition#3550
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Aug 9, 2016
Merged
[aspnet] Honor casing of properties from definition#3550wing328 merged 1 commit intoswagger-api:masterfrom
wing328 merged 1 commit intoswagger-api:masterfrom
Conversation
Contributor
|
@jimschubert thanks for the PR. The change looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3262
This would replace #3263, which provides a correct implementation for JSON endpoints only. Although generated code for the
aspnet5generator outputs to JSON, we still need to support all output types (i.e. from theproducesdefinition of the api endpoint).I've also fixed the formatting in the
ToStringmethod for models and changed the generic description on enums which was previously worded like an auto-implemented property description.