Skip to content

[Java] Fix UUID mapping to a UUID instead of a string#3741

Merged
wing328 merged 1 commit intoswagger-api:2.3.0from
cvent:cvent-2.3.0
Sep 18, 2016
Merged

[Java] Fix UUID mapping to a UUID instead of a string#3741
wing328 merged 1 commit intoswagger-api:2.3.0from
cvent:cvent-2.3.0

Conversation

@brentryan
Copy link
Copy Markdown

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

It looks like there was a commit back in January that reverted a previous fix that added UUID types for java. The commit is 7aac639.

This fixes the issue by allowing UUID to be used in generated code.

@brentryan
Copy link
Copy Markdown
Author

See #3732 (This is a redo of that PR into 2.3.0)

@wing328 wing328 closed this Sep 8, 2016
@wing328 wing328 reopened this Sep 8, 2016
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Sep 12, 2016

@brentryan CI failed because you've removed Java (jersey1) Petstore sample. Please review the change.

@brentryan
Copy link
Copy Markdown
Author

@wing328 fixed.

@wing328 wing328 closed this Sep 13, 2016
@wing328 wing328 reopened this Sep 13, 2016
@wing328 wing328 merged commit d5c88ae into swagger-api:2.3.0 Sep 18, 2016
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Sep 18, 2016

@brentryan PR merged. Thanks for the contribution.

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Sep 18, 2016

Upgrade Note

Starting from v2.3.0, Java generators (API client, server stubs) will map the following defintion to java.util.UUID in Java

type: string
format: uuid

@wing328 wing328 changed the title Java: Fix UUID mapping to a UUID instead of a string [Java] Fix UUID mapping to a UUID instead of a string Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants