[PHP] Change APIException to expect headers as array#3838
Merged
wing328 merged 2 commits intoswagger-api:2.3.0from Sep 22, 2016
kimsondrup:php-exception-headers
Merged
[PHP] Change APIException to expect headers as array#3838wing328 merged 2 commits intoswagger-api:2.3.0from kimsondrup:php-exception-headers
wing328 merged 2 commits intoswagger-api:2.3.0from
kimsondrup:php-exception-headers
Conversation
Contributor
|
@BeneficialName thanks for the PR. I agree that it's a breaking change that should be submitted against the 2.3.0 branch. cc @arnested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the ApiClient the headers param is always given array or null so the PHPDoc is definitely wrong.
I have made the pull request to v2.3.0 since the change of ApiException constructor param from
$responseHeaders = nulltoarray $responseHeaders = nulltechnically speaking breaks backward compatibility by forcing array or null.