Skip to content

Mention security script in pull request template#3875

Merged
wing328 merged 1 commit intoswagger-api:masterfrom
arnested:mention-security-script-in-pull-request-template
Sep 28, 2016
Merged

Mention security script in pull request template#3875
wing328 merged 1 commit intoswagger-api:masterfrom
arnested:mention-security-script-in-pull-request-template

Conversation

@arnested
Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

The pull request template only mentions regeneration scripts in ./bin/. I added ./bin/security/ as well to also keeping those samples updated.

@wing328 wing328 merged commit a090ce0 into swagger-api:master Sep 28, 2016
@arnested arnested deleted the mention-security-script-in-pull-request-template branch September 28, 2016 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants