[ObjC] Added support for lower case discriminator#3927
Merged
wing328 merged 3 commits intoswagger-api:masterfrom Oct 6, 2016
Merged
[ObjC] Added support for lower case discriminator#3927wing328 merged 3 commits intoswagger-api:masterfrom
wing328 merged 3 commits intoswagger-api:masterfrom
Conversation
wing328
reviewed
Oct 5, 2016
| } | ||
| Class class = NSClassFromString([@"{{classPrefix}}" stringByAppendingString:discriminatedClassName]); | ||
| if(!class){ | ||
| class = NSClassFromString([@"{{classPrefix}}" stringByAppendingString:[discriminatedClassName capitalizedString]]); |
Contributor
There was a problem hiding this comment.
We prefer 4-space indentation. Please also add a space before { in line 31
Contributor
|
Please also run |
Contributor
|
Would this change cater both lowercase discriminator and discriminator in the original form (e.g. PascalCase) ? |
added 2 commits
October 6, 2016 12:32
Contributor
Author
|
Yes the original behavior is preserved. In case the original behavior doesn't succeed, it tries to uppercase the first letter of the discriminant. |
Contributor
|
@sylvain-abadie thanks for the explanation. PR merged into master. |
acramatte
added a commit
to comerge/swagger-codegen
that referenced
this pull request
Oct 10, 2016
* upstream/master: [aspnet] Fix .sln/.xproj guids [Python][Flask] fix python2 support in Flask (swagger-api#3952) Bugfix/3929 do not set multipart (swagger-api#3932) fix python required property check and validation for optional properties required tag is used in model, allows null values (swagger-api#3923) fix number format for dart model support number enum for swift [Objc] Added support for lower case discriminator (swagger-api#3927) [Android][Volley] add serializeModel support to Android (swagger-api#3933) add more info about test with latest master add back java okhttp petstore client fix pom duplicated id issue update pom to test java okhttp-gson parcelable models fix bug with parcelable [Java] Fix bug in generated code if parcelableModel and serializableModel are both true. [Java] Make generated models Parcelable for okhttp-gson if the -DparcelableModel=true option is provided. add http://onedata.org validate(s)_presence_of Migration should create pluralized table names Change controller filenames Issue#3829. Objective-C client code, discriminator generated in both base and child.
wing328
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Add support for lowercase discriminator. Currently if the discriminator is "cat" (and not "Cat") the Cat class won't be deserialized. This just adds a test to deserialize by adding an uppercase to the discriminator.