[Python] Allow multiple requests in parallel in Python client#4187
Merged
wing328 merged 2 commits intoswagger-api:masterfrom Nov 18, 2016
Merged
[Python] Allow multiple requests in parallel in Python client#4187wing328 merged 2 commits intoswagger-api:masterfrom
wing328 merged 2 commits intoswagger-api:masterfrom
Conversation
If you tried to do two parallel calls to the same API object in the Python client you would get an error from urllib3 connection pool: Connection pool is full, discarding connection: *** Because the default maxsize=1: https://github.com/shazow/urllib3/blob/f9409436f83aeb79fbaf090181cd81b784f1b8ce/urllib3/connectionpool.py#L162 By defaulting to a higher maxsize we mitigate for the common use case where a user is running a couple of requests in parallel. Ideally, in the future, this should be a configuration paramater together with the pool size.
Contributor
|
@hermansc thanks for the PR. Please run cc @scottrw93 |
Contributor
Author
|
@wing328 Thanks for picking up this one. I've added the sample code now - just forgot to add it to my commit earlier. |
Contributor
|
@hermansc thanks for the PR. May I know if you've time to add |
Contributor
Author
|
@wing328 I'll have a look at it this weekend :) |
wing328
changed the title
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
* Allow multiple requests in parallel in Python client If you tried to do two parallel calls to the same API object in the Python client you would get an error from urllib3 connection pool: Connection pool is full, discarding connection: *** Because the default maxsize=1: https://github.com/shazow/urllib3/blob/f9409436f83aeb79fbaf090181cd81b784f1b8ce/urllib3/connectionpool.py#L162 By defaulting to a higher maxsize we mitigate for the common use case where a user is running a couple of requests in parallel. Ideally, in the future, this should be a configuration paramater together with the pool size. * Add sample code after changing maxsize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
If you tried to do two parallel calls to the same API object in the Python client you would get an error from urllib3 connection pool:
Because the default maxsize=1
By defaulting to a higher maxsize we mitigate for the common use case where a user is running a couple of requests in parallel.
Ideally, in the future, this should be a configuration parameter together with the pool size.