Skip to content

[JAXRS-RS-CDI] Add a basic JAX-RS Application and CDI fixes#4196

Merged
wing328 merged 4 commits intoswagger-api:masterfrom
nickcmaynard:jaxrs-cxf-cdi-application
Nov 18, 2016
Merged

[JAXRS-RS-CDI] Add a basic JAX-RS Application and CDI fixes#4196
wing328 merged 4 commits intoswagger-api:masterfrom
nickcmaynard:jaxrs-cxf-cdi-application

Conversation

@nickcmaynard
Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Add a JAX-RS application, and beans.xml, so that this works on typical JavaEE 7.0 servers. For example, code generated by this generator will now work directly upon deployment to IBM WAS Liberty, and IBM Bluemix.

@nickcmaynard
Copy link
Copy Markdown
Contributor Author

... This fixes a fairly nasty bug where this code, while compiling, doesn't actually work on a real server without extra work.

@nickcmaynard
Copy link
Copy Markdown
Contributor Author

@wing328 It would be great if we could make sure this goes into v2.2.2

@nickcmaynard nickcmaynard force-pushed the jaxrs-cxf-cdi-application branch from ac2391d to 0581eed Compare November 17, 2016 08:34
@nickcmaynard nickcmaynard force-pushed the jaxrs-cxf-cdi-application branch from 0581eed to 3be204f Compare November 17, 2016 08:54
@nickcmaynard
Copy link
Copy Markdown
Contributor Author

@wing328 Sorry to ask, but do you think it might be possible to merge this reasonably swiftly? I have an article pending publication in which I make some statements about this generator (will drop a link in here once it's published) and it'd be great to unblock it...

@wing328 wing328 merged commit b7e9603 into swagger-api:master Nov 18, 2016
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Nov 18, 2016

@nickcmaynard PR merged and thanks for mentioning Swagger Codegen in your publication.

@nickcmaynard
Copy link
Copy Markdown
Contributor Author

Thank you!

@wing328 wing328 changed the title jaxrs-cxf-cdi :: Add a basic JAX-RS Application and CDI fixes [jaxrs-cxf-cdi] Add a basic JAX-RS Application and CDI fixes Feb 21, 2017
@wing328 wing328 changed the title [jaxrs-cxf-cdi] Add a basic JAX-RS Application and CDI fixes [JAXRS-RS-CDI] Add a basic JAX-RS Application and CDI fixes Feb 21, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
…r-api#4196)

* Add a basic JAX-RS Application and CDI fixes

* jaxrs-cxf-cdi :: Fix samples generation template dir

* jaxrs-cxf-cdi :: Regenerate samples

* jaxrs-cxf-cdi :: Clean up some checkstyle warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants