[html2] Add missing enums to parameters#4204
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Nov 17, 2016
bshamblen:master
Merged
[html2] Add missing enums to parameters#4204wing328 merged 1 commit intoswagger-api:masterfrom bshamblen:master
wing328 merged 1 commit intoswagger-api:masterfrom
bshamblen:master
Conversation
Contributor
|
@bshamblen thanks for the PR, which has been merged into the master. |
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
[html2] Add missing enums to parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enumvalues were not being displayed in the Parameters section. Enums are now displayed next to the Enums: label, as a comma separated list.I also cleaned up the HTML formatting if the index.mustache page, to make it easier to read and debug.
Lastly, I hid the Schema block below the response code, if no schema was defined. For example, when a 401 error is defined, if there's no
schemaspecified, the empty schema tab and panel body below that header are no longer rendered. It was taking up a lot of vertical space having a bunch of empty schema blocks for each endpoint.