Allow Java source formatting mvn formatter:format#4214
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Nov 23, 2016
Merged
Allow Java source formatting mvn formatter:format#4214wing328 merged 1 commit intoswagger-api:masterfrom
wing328 merged 1 commit intoswagger-api:masterfrom
Conversation
cf56ab4 to
04efe5b
Compare
Uses Eclipse formatting tools with a configuration matching Google's style guide (plus our customisations).
04efe5b to
9b63dcb
Compare
Contributor
|
@nickcmaynard thanks for the PR. I'll run |
Contributor
Author
|
@wing328 Do you think the codebase is ready for a formatter run yet? |
Contributor
|
@nickcmaynard I'll do it after merging latest enhancements in the master to |
Contributor
Author
|
Fair - this will cause some conflicts. Just making sure it doesn't get buried under all the other stuff you're doing! |
Contributor
|
Yup, I've created #4295 for tracking. |
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
Uses Eclipse formatting tools with a configuration matching Google's style guide (plus our customisations).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
More work towards our code style standards aim #3972.
Uses Eclipse formatting tools with a configuration matching Google's style guide (plus our customisations).
This brings in an appropriately configured Java formatter maven plugin, but doesn't run it as part of the build. To manually run it:
mvn formatter:formatHaving done this once, we fix ~2200 code style warnings.
I haven't included the results of a run in this PR, as it would generate lots of merge conflicts... I'd suggest whoever merges this PR does a once-off formatter run.