fix the value for @Generated java annotation#4366
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Dec 12, 2016
Merged
Conversation
com.my.Generator.class.toString() returns "class com.my.Generator", and this value is then used in the javax.annotation.Generated annotation like that: @generated(value = "class com.my.Generator"). Should use Generator.class.getName() instead, so we end up with @generated(value = "com.my.Generator")
Contributor
|
@trigan-d The change looks good to me. Thanks for the PR to fix the issue. |
Contributor
|
(If your company is using Swagger Codegen, please consider adding your company name to this list) |
3 tasks
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
com.my.Generator.class.toString() returns "class com.my.Generator", and this value is then used in the javax.annotation.Generated annotation like that: @generated(value = "class com.my.Generator"). Should use Generator.class.getName() instead, so we end up with @generated(value = "com.my.Generator")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
com.my.Generator.class.toString() returns "class com.my.Generator", and this value is then used in the javax.annotation.Generated annotation like that: @generated(value = "class com.my.Generator").
Should use Generator.class.getName() instead, so we end up with @generated(value = "com.my.Generator")