[Scalatra] Fix CSV collection parameter issues for scalatra server#4426
Merged
wing328 merged 2 commits intoswagger-api:masterfrom Dec 20, 2016
jtnystrom:issue-3806
Merged
[Scalatra] Fix CSV collection parameter issues for scalatra server#4426wing328 merged 2 commits intoswagger-api:masterfrom jtnystrom:issue-3806
wing328 merged 2 commits intoswagger-api:masterfrom
jtnystrom:issue-3806
Conversation
jtnystrom
changed the title
Contributor
|
@jtnystrom thank you for the PR, which has been merged into master. (If your company is using Swagger Codegen, please consider adding your company name to this list) |
Contributor
|
Linked to #3806 |
wing328
changed the title
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
…4426) * Fix scalatra handling of CSV query parameters * Ran petstore for scalatra server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Scalatra server generated code had two issues that broke CSV format collection parameters (see issue 3806). The comparison "default".equals("csv") prevented the parameters from ever being parsed, and if they had been parsed, the type of the parsed data would have been just Serializable (impossible to use). This fixes both issues.