Skip to content

[codegen ignore] normalize path separator for Windows, add *.ext tests#4476

Merged
wing328 merged 2 commits intoswagger-api:masterfrom
jimschubert:codegen-ignore/4452
Jan 3, 2017
Merged

[codegen ignore] normalize path separator for Windows, add *.ext tests#4476
wing328 merged 2 commits intoswagger-api:masterfrom
jimschubert:codegen-ignore/4452

Conversation

@jimschubert
Copy link
Copy Markdown
Contributor

@jimschubert jimschubert commented Dec 31, 2016

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Add missing tests for simple globbed ignore pattern which is not nested and not explicitly rooted...

See comment in Rule.java:

// case 1
//: If the pattern does not contain a slash '/', Git treats it as
//: a shell glob pattern and checks for a match against the
//: pathname relative to the location of the `.gitignore` file
//: (relative to the toplevel of the work tree if not from a
//: `.gitignore` file).

see #4452

@wing328 wing328 added this to the v2.2.2 milestone Jan 3, 2017
@wing328 wing328 merged commit c94e18a into swagger-api:master Jan 3, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
swagger-api#4476)

* [codegen ignore] Fix windows paths for ignore processing

* [codegen ignore] Add missing glob rule tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants