[Swift3] allow POST with both body and query parameters#4490
Merged
wing328 merged 2 commits intoswagger-api:masterfrom Jan 7, 2017
Merged
[Swift3] allow POST with both body and query parameters#4490wing328 merged 2 commits intoswagger-api:masterfrom
wing328 merged 2 commits intoswagger-api:masterfrom
Conversation
Contributor
Author
|
Interesting, check failed for seemingly unrelated reason: |
Contributor
|
@tomekc thanks for the PR. The test result looks good: |
Contributor
|
+1 @wing328 |
Contributor
|
+1 @wing328 One thing I'd add is some scenario where a call "mapValuesToQueryItems" is generated. There's no such scenario in the current petstore. |
Contributor
|
@hexelon good idea. We might want to leverage the fake Petstore for the additional test case |
Contributor
Author
|
@wing328 @hexelon Speaking about tests, I have more improvements underway and found http://httpbin.org useful for testing all possible request types. |
wing328
changed the title
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
…4490) * [swift3] allow POST with both body and query parameters * Correctly support non-string and optional query parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Made POST requests allow use query parameters, besides of body. Currently generated code ignores all query parameters when body exists.
Reported in #2557 and also in #2483
Note
This is a workaround of flawed Alamofire API which is actual limitation. Next time I will post a Alamofire-less template :)