Always use configured host at runtime #4540
Closed
philip wants to merge 2 commits intoswagger-api:masterfrom
Closed
Always use configured host at runtime #4540philip wants to merge 2 commits intoswagger-api:masterfrom
philip wants to merge 2 commits intoswagger-api:masterfrom
Conversation
value set at runtime, otherwise use the default
* Currently the runtime value is ignored unless you do something like
the following (instantiate the api client, empty or otherwise):
$api_client = new Swagger\Client\ApiClient();
$foo = new Swagger\Client\Api\Bar($api_client);
But now all you need is:
$foo = new Swagger\Client\Api\Bar();
* This use case is common if host is not defined in the swagger file
* This now allows the host to be set at runtime under any condition,
for example using either:
* lib/Configuration.php $host
* Swagger\Client\Configuration::getDefaultConfiguration()->setHost($host)
* This could change behavior for some, as it means the configured host
is used instead of the default, unless api client is instantiated first.
Not sure why someone would do that, likely by accident.
* This resolves swagger-api#4518
This contains unrelated changes, perhaps a different commit forgot to commit these changes? I'm including those, too.
3 tasks
Author
|
This was fixed in PR #4525 so closing this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
at runtime, otherwise use the default
the following (instantiate the api client, empty or otherwise):
$api_client = new Swagger\Client\ApiClient();
$foo = new Swagger\Client\Api\Bar($api_client);
But now all you need is:
$foo = new Swagger\Client\Api\Bar();
for example using either:
is used instead of the default, unless api client is instantiated first.
Not sure why someone would do that, likely by accident.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)