Skip to content

[PHP] Validate parent's model first, if any#4659

Merged
wing328 merged 3 commits intoswagger-api:masterfrom
nazieb:validate-parent-model
Jan 26, 2017
Merged

[PHP] Validate parent's model first, if any#4659
wing328 merged 3 commits intoswagger-api:masterfrom
nazieb:validate-parent-model

Conversation

@nazieb
Copy link
Copy Markdown
Contributor

@nazieb nazieb commented Jan 26, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

On PHP generated models, if they have parent, the valid() & listInvalidProperties() method will lookup the parent's first.

Close #4530

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Jan 26, 2017

@nazieb the PR looks good to me. I'll merge it later today.

cc @arnested

@wing328 wing328 merged commit 05eea24 into swagger-api:master Jan 26, 2017
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Jan 26, 2017

@nazieb PR merged. Thanks for your contribution.

@nazieb nazieb deleted the validate-parent-model branch January 26, 2017 21:33
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
* if model has parent, valid() & listInvalidProperties() will check the parents' first

* Run the ./bin/security/php-petstore.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants