Skip to content

[JS] Fixed handling of empty arrays/empty strings/booleans/single numbers as valid API responses#4666

Merged
wing328 merged 1 commit intoswagger-api:masterfrom
frol:issue-4653
Jan 28, 2017
Merged

[JS] Fixed handling of empty arrays/empty strings/booleans/single numbers as valid API responses#4666
wing328 merged 1 commit intoswagger-api:masterfrom
frol:issue-4653

Conversation

@frol
Copy link
Copy Markdown
Contributor

@frol frol commented Jan 27, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Fixes #4653.

/cc @khorolets @wing328 @jordanyaker

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Jan 27, 2017

@frol thanks for the quick fix, which looks good to me.

I'll merge it over the weekend if no one has further feedback/question.

@frol
Copy link
Copy Markdown
Contributor Author

frol commented Jan 27, 2017

@khorolets Please, test this fix (you can just apply the patch manually).

@khorolets
Copy link
Copy Markdown

@frol @wing328 I've patched manually my code and I can confirm the fix works great.

@wing328 wing328 merged commit 6890ef9 into swagger-api:master Jan 28, 2017
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Jan 28, 2017

PR merged into master. Thanks again for the quick fix from @frol

@wing328 wing328 changed the title [JavaScript] Fixed handling of empty arrays/empty strings/booleans/single numbers as valid API responses [JS] Fixed handling of empty arrays/empty strings/booleans/single numbers as valid API responses Feb 20, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants