[Jaxrs-spec] fix usage of Jersey templates in shellscript#4722
[Jaxrs-spec] fix usage of Jersey templates in shellscript#4722wing328 merged 2 commits intoswagger-api:masterfrom
Conversation
|
@wing328 pls merge this when you have time, this fixes the currently wrong samples for jaxrs-spec and the corresponding shellscript. |
|
@jfiala sure. Let me review later ... |
| "required" : false, | ||
| "type" : "number", | ||
| "maximum" : 987.6, | ||
| "maximum" : 987.6000000000000227373675443232059478759765625, |
There was a problem hiding this comment.
@jfiala this is weird. Can you rebase this PR on the latest master and generate the sample again to see if the issue (long decimal) goes away?
There was a problem hiding this comment.
I rebased and regenerated, but nothing changed, it shows still the float value (and it should have nothing to do with my change...).
There was a problem hiding this comment.
I used the latest master to run ./bin/jaxrs-spec-petstore-server.sh but couldn't repeat the issue.
There was a problem hiding this comment.
Currently jaxrs-spec-petstore-server.sh uses the wrong templates (Jaxrs-Jersey!), you have to remove the "-t modules/swagger-codegen/src/main/resources/JavaJaxRS" flag in the shellscript, otherwise you are generating using the Jersey templates...
There was a problem hiding this comment.
I did a test with this PR and I got different results when running ./bin/jaxrs-spec-petstore-server.sh: faa453d, which has new issues (e.g. integer becomes decimal...)
There was a problem hiding this comment.
I'm on windows so I had to reassmble the shellscript, but in fact that shouldn't change the outcome. Anyway, please correct the shellscript and the samples, so we have a green state here again.
There was a problem hiding this comment.
Just to be clear. I'm not saying your PR causes the issue we're seeing.
Looks like we discovered some new issues, probably due to Swagger Parser. I'm actually performing more tests to confirm the "behaviour".
There was a problem hiding this comment.
I've merged the PR into master and updated the sample.
Can you pull the latest to give it another try to see if the issue (long decimal) is repeatable?
There was a problem hiding this comment.
I pulled the master and now everything is fine, thanks (issue does not occur, float looks fine)!
* 'master' of github.com:swagger-api/swagger-codegen: (40 commits) remove default temp folder during initalization (swagger-api#4749) [Java-retrofit] Fix for swagger-api#4750 String comparison with equals (swagger-api#4751) update java server stub samples with new uuid mapping update java petstore with new uuid mapping [Java-Feign] Fixed String comparison using equals instead of == operator (swagger-api#4740) add SPINEN update jaxrs spec petstore sample (mac) [Jaxrs-spec] fix usage of Jersey templates in shellscript (swagger-api#4722) [Bash] Bash generator improvements (swagger-api#4730) [Java][Issue swagger-api#1806] generate using java.util.UUID for UUIDs Revert "rx2 support" (swagger-api#4737) rx2 support (swagger-api#4708) add https and change order for HPE add Hewlett Packard Enterprise (hpe.com) Add "Simpfony" to list of companies using Swagger (swagger-api#4726) add https://www.slamby.com/ [csharp] Fix enum default value (swagger-api#4681) fix issue swagger-api#4672 - XmlExampleGenerator does not properly handle properties of several numeric types (swagger-api#4673) [JAXRS-CXF] Issue 4569 - Re-added usage of contextPath in api.mustache (basePath) (swagger-api#4580) [Jaxrs-cxf-cdi] merge beanvalidation templates to single one swagger-api#4719 (swagger-api#4723) ...
* master: (40 commits) remove default temp folder during initalization (swagger-api#4749) [Java-retrofit] Fix for swagger-api#4750 String comparison with equals (swagger-api#4751) update java server stub samples with new uuid mapping update java petstore with new uuid mapping [Java-Feign] Fixed String comparison using equals instead of == operator (swagger-api#4740) add SPINEN update jaxrs spec petstore sample (mac) [Jaxrs-spec] fix usage of Jersey templates in shellscript (swagger-api#4722) [Bash] Bash generator improvements (swagger-api#4730) [Java][Issue swagger-api#1806] generate using java.util.UUID for UUIDs Revert "rx2 support" (swagger-api#4737) rx2 support (swagger-api#4708) add https and change order for HPE add Hewlett Packard Enterprise (hpe.com) Add "Simpfony" to list of companies using Swagger (swagger-api#4726) add https://www.slamby.com/ [csharp] Fix enum default value (swagger-api#4681) fix issue swagger-api#4672 - XmlExampleGenerator does not properly handle properties of several numeric types (swagger-api#4673) [JAXRS-CXF] Issue 4569 - Re-added usage of contextPath in api.mustache (basePath) (swagger-api#4580) [Jaxrs-cxf-cdi] merge beanvalidation templates to single one swagger-api#4719 (swagger-api#4723) ...
…i#4722) * remove jersey templates swagger-api#4720 * regenerate sample with jaxrs-spec templates swagger-api#4720
2 participants
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
see #4720