[Jaxrs-cxf] add ApiResponse/s to operation #4718#4920
Merged
wing328 merged 7 commits intoswagger-api:masterfrom Mar 12, 2017
Merged
[Jaxrs-cxf] add ApiResponse/s to operation #4718#4920wing328 merged 7 commits intoswagger-api:masterfrom
wing328 merged 7 commits intoswagger-api:masterfrom
Conversation
Open
9 tasks
wing328
reviewed
Mar 8, 2017
| cliOptions.add(new CliOption("title", "a title describing the application")); | ||
|
|
||
| cliOptions.add(CliOption.newBoolean(USE_BEANVALIDATION, "Use BeanValidation API annotations")); | ||
| cliOptions.add(CliOption.newBoolean(USE_BEANVALIDATION, "Use BeanValidation API annotations")); |
Contributor
There was a problem hiding this comment.
@jfiala This line is not aligned properly (missing 2 spaces)
wing328
reviewed
Mar 8, 2017
| if (additionalProperties.containsKey(USE_BEANVALIDATION)) { | ||
| this.setUseBeanValidation(convertPropertyToBoolean(USE_BEANVALIDATION)); | ||
| } | ||
| if (additionalProperties.containsKey(USE_BEANVALIDATION)) { |
wing328
reviewed
Mar 8, 2017
| public void addPetTest() { | ||
| Pet body = null; | ||
| //api.addPet(body); | ||
| //api.addPet(body); |
Contributor
There was a problem hiding this comment.
Seems like missing a space and I don't think it's caused by the change in this PR. Still it would be nice if you can fix it in this PR.
Contributor
Author
|
@wing328 fixed alignment issues from your review & replaced tabs. |
Contributor
|
@jfiala thanks for the update. PR merged into master. |
spr3nk3ls
pushed a commit
to spr3nk3ls/swagger-codegen
that referenced
this pull request
Mar 28, 2017
…api#4920) * add ApiResponse/s to operation swagger-api#4718 * use spaces instead of tabs swagger-api#4718 * fix alignment issues swagger-api#4920 * fix alignment issues swagger-api#4920 * replace tabs with spaces swagger-api#4920 * updated samples swagger-api#4920
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Implemented #4718 for CXF.