Update Spring Fox dependency version to 2.6.1. This fixes a defect wh…#4993
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Mar 22, 2017
Merged
Update Spring Fox dependency version to 2.6.1. This fixes a defect wh…#4993wing328 merged 1 commit intoswagger-api:masterfrom
wing328 merged 1 commit intoswagger-api:masterfrom
Conversation
…ere Swagger and Feign clients do not conflict when registration occurs with Eureka.
Contributor
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors. Let me know if you need help fixing it. |
Contributor
|
For your upcoming PRs. I would suggest you to create a new branch for the change as pert git best practices. |
Contributor
|
Can you please also run the following to update the Petstore sample for SpringBoot-related generators? The updated Petstore samples will be tested by CIs so as to verify the change. |
Closed
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a defect with eureka registration on port 8080 no matter what server.port is specified in Spring Boot config.
Fixed this by adding SpringBoot 1.4.5 dependency with Spring Fox 2.6.1. Swagger and Feign clients have a conflict when registration occurs with Eureka. SpringFox has fixed the defect in version 2.6.1
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Tests have been done with a sample yaml file and generated pom file as expected. Runtime tests were done to ensure swagger-ui still work on spring boot.