Skip to content

Update Spring Fox dependency version to 2.6.1. This fixes a defect wh…#4993

Merged
wing328 merged 1 commit intoswagger-api:masterfrom
techlogix:master
Mar 22, 2017
Merged

Update Spring Fox dependency version to 2.6.1. This fixes a defect wh…#4993
wing328 merged 1 commit intoswagger-api:masterfrom
techlogix:master

Conversation

@techlogix
Copy link
Copy Markdown
Contributor

Fixes a defect with eureka registration on port 8080 no matter what server.port is specified in Spring Boot config.

@EnableSwagger2
@EnableDiscoveryClient

Fixed this by adding SpringBoot 1.4.5 dependency with Spring Fox 2.6.1. Swagger and Feign clients have a conflict when registration occurs with Eureka. SpringFox has fixed the defect in version 2.6.1

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Tests have been done with a sample yaml file and generated pom file as expected. Runtime tests were done to ensure swagger-ui still work on spring boot.

…ere Swagger and Feign clients do not conflict when registration occurs with Eureka.
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Mar 10, 2017

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Mar 10, 2017

For your upcoming PRs. I would suggest you to create a new branch for the change as pert git best practices.

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Mar 10, 2017

Can you please also run the following to update the Petstore sample for SpringBoot-related generators?

springboot-petstore-server-implicitHeaders.sh
springboot-petstore-server.sh

The updated Petstore samples will be tested by CIs so as to verify the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants