Merged
Conversation
3 tasks
AnthonyOliveri
changed the title
Contributor
|
+1 looks good thanks |
Contributor
|
@jaz-ah thanks for reviewing the change. @AnthonyOliveri thanks for the PR, which has been merged into master. I'll create a task to review other generators to make sure |
spr3nk3ls
pushed a commit
to spr3nk3ls/swagger-codegen
that referenced
this pull request
Mar 28, 2017
…issue-4764 [Swift] Fix issue swagger-api#4764
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates) - This does not affect the Petstore sample2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Adds file type detection to Swift codegen, which was previously missing. This was causing Swift codegen to never know when a parameter or response type was defined with type file.
This fixes issue #4764.