Add switch to enable template rendering via handlebars#5365
Open
tgmuender wants to merge 1 commit intoswagger-api:masterfrom
Open
Add switch to enable template rendering via handlebars#5365tgmuender wants to merge 1 commit intoswagger-api:masterfrom
tgmuender wants to merge 1 commit intoswagger-api:masterfrom
Conversation
Contributor
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors. Let me know if you need help fixing it. |
Contributor
|
Can you please also elaborate on what this PR does? Is there an issue/ticket opened for this? |
Author
|
Wow, thanks for the quick reply.
Thanks for the hint with the contributions, I have updated my email
addresses to include the one I used in the commit.
I did not create separate ticket, but the closest ticket is this one:
#3950 (discussion
about different template engines)
The pull request allows to use the handlebars template engine by
additionally setting the system property "'Dhandlebars", e.g.
java -Dmodels -Dhandlebars -cp swagger-codegen-cli.jar
io.swagger.codegen.SwaggerCodegen generate \
-l java \
-t handlebarsTemplateLocation
If the "-Dhandlebars" system property is not present, everything will be
rendered with the Mustache engine.
Thanks and best regards,
Tobias
2017-04-11 13:07 GMT+02:00 wing328 <notifications@github.com>:
… Can you please also elaborate on what this PR does? Is there an
issue/ticket opened for this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5365 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACQPpwvLVq9eqWxbIpVqCQsMbChVuS-sks5ru17mgaJpZM4M57S_>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)