Skip to content

[TypeScript][Angular1,2] fix class filename in import/export#5396

Merged
wing328 merged 2 commits intoswagger-api:masterfrom
TiFu:fixClassFilenameTS
Apr 17, 2017
Merged

[TypeScript][Angular1,2] fix class filename in import/export#5396
wing328 merged 2 commits intoswagger-api:masterfrom
TiFu:fixClassFilenameTS

Conversation

@TiFu
Copy link
Copy Markdown
Contributor

@TiFu TiFu commented Apr 13, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

import { UserApi } from './UserApi';
export const APIS = [ PetApi, StoreApi, UserApi, ];
import { UserApi } from './UserApi';
export const APIS = [PetApi, StoreApi, UserApi, ];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TiFu FYI. I'll file a PR later to remove the trailing comma.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: fixed via #5563

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Apr 17, 2017

@TiFu thanks for the PR, which looks good to me.

@wing328 wing328 merged commit e858f23 into swagger-api:master Apr 17, 2017
@wing328 wing328 changed the title [TypeScript] fix class filename in import/export [TypeScript][Angular1,2] fix class filename in import/export May 5, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
* Fixed classFilename in typescript-angular and recreated samples

* Changed classname to classFilename in ts-angular2/models.mustache
Also recreated ts-angular2 sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants