[PHP] add Accept encoding using CURLOPT_ENCODING#5525
Merged
wing328 merged 1 commit intoswagger-api:masterfrom May 6, 2017
Merged
[PHP] add Accept encoding using CURLOPT_ENCODING#5525wing328 merged 1 commit intoswagger-api:masterfrom
wing328 merged 1 commit intoswagger-api:masterfrom
Conversation
Contributor
|
@mguan-trulia thanks for the PR. |
dkarlovi
reviewed
May 2, 2017
| * Allow Curl encoding header | ||
| * | ||
| * @var bool | ||
| */ |
dkarlovi
approved these changes
May 2, 2017
Contributor
dkarlovi
left a comment
dkarlovi
left a comment
There was a problem hiding this comment.
Only one style change, overall the change is OK.
| * Allow Curl encoding header | ||
| * | ||
| * @var bool | ||
| */ |
Contributor
mguan-trulia
force-pushed
the
add-php-client-allow-encoding
branch
from
a6a9658 to
9c1a4b4
Compare
Contributor
Author
|
Thanks for the comments @dkarlovi , I've made the variable name change as suggested. Thank you for letting me know about the Guzzle option. That is preferable for what I'm working on going forward. |
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
wing328
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
This change is to implement PHP client for allowing encoding headers.
#3365