[php] 2.3 - fix form params json encoding#5701
Merged
wing328 merged 4 commits intoswagger-api:2.3.0from Jun 4, 2017
baartosz:php_fixFormParamsJsonEncoding
Merged
[php] 2.3 - fix form params json encoding#5701wing328 merged 4 commits intoswagger-api:2.3.0from baartosz:php_fixFormParamsJsonEncoding
wing328 merged 4 commits intoswagger-api:2.3.0from
baartosz:php_fixFormParamsJsonEncoding
Conversation
wing328
reviewed
May 25, 2017
| } | ||
| $httpBody = new MultipartStream($multipartContents); // for HTTP post (form) | ||
|
|
||
| } elseif ($headers['Content-Type'] === 'application/json') { |
Contributor
There was a problem hiding this comment.
@baartosz do you mind adding a new method (e.g. isJsonMime) to determine if a MIME string is "JSON"?
and here are some tests:
Contributor
There was a problem hiding this comment.
I'll create a separate task to track this.
Contributor
Contributor
|
@baartosz when you've time, I wonder if you can contact me via the email address in my Github profile as I've some questions for you (not related to this PR). Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Issue introduced when client was reworked to use guzzle instead of curl in #5190.
Apparently I missed this case earlier. Content of request is not json-encoded if endpoint
consumes: application/jsonand params are informData. This PR fixes this issue.I added example of spec causing this issue to FakeApi definition so I could add test for it.