Change all sample-generators for typescript-angular2-* to use YAML#5859
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Jul 2, 2017
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. → bin/typescript-angular2-petstore*.sh (see below)Description of the PR
No functional changes, just different options for sample generation scripts.
There were several scripts generating samples in samples/client/petstore/typescript-angular2/*:
Depending on whether you ran the -all script or the individual ones (or if both, depending on the order), you got different results, leading to spurious changes in diffs.
As the most recent change of yaml/json in those files was json → yaml in 1fc969b, I chose to use YAML for the new coherent source. (It also seems to agree with the current state of the samples in master for default+NPM, though of course not for -interfaces).
Now running either of the scripts last doesn't change anything in the generated samples.