Moving instantiationTypes, typeMappings, languageSpecificPrimitives, additionalProperties, and reservedWordsMappings out of configOptions and converting it into a list, rather than being a comma-separated string.#6063
Merged
fehguy merged 3 commits intoswagger-api:masterfrom Jul 14, 2017
zmoore-usgs:feature/move-config-options
Merged
Moving instantiationTypes, typeMappings, languageSpecificPrimitives, additionalProperties, and reservedWordsMappings out of configOptions and converting it into a list, rather than being a comma-separated string.#6063fehguy merged 3 commits intoswagger-api:masterfrom zmoore-usgs:feature/move-config-options
fehguy merged 3 commits intoswagger-api:masterfrom
zmoore-usgs:feature/move-config-options
Conversation
…additionalProperties, and reservedWordsMappings out of configOptions and converting it into a list, rather than being a comma-separated string.
…e string application functions.
Contributor
|
Please see my comment on the linked issue. |
Contributor
Author
|
@fehguy My implementation does handle the old format as well, in the same way as #5384 which was merged. See https://github.com/swagger-api/swagger-codegen/pull/6063/files#diff-728390e70cc7f684e2ecec961cd583ffR438 and the functions around it. |
Contributor
|
Hmm how did i miss this :-S |
Contributor
|
The travis PR failed with: I'm boldly going to merge regardless, after looking at the remaining tests (they have nothing to do with this PR). cc: @wing328 as a FYI |
Contributor
Author
|
Thanks for the responsiveness on this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
In the same vein as (and following the pattern established by) #5384 this converts
instantiation-types,type-mappings,language-specific-primitives,additional-properties, andreserved-words-mappingsto lists and moves them outside of configOptions, while still maintaining backwards compatibility. Fixes #6062This adds support to having configuration like this (same example from #5384 converted to show type mappings):